fix: add build() function to json_goal tracer for explicit loading#121
Closed
fix: add build() function to json_goal tracer for explicit loading#121
Conversation
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | f1faa4e |
| fmdeps/BRiCk/ | main | b62cb51 |
| fmdeps/auto/ | main | 2a53fc0 |
| fmdeps/auto-docs/ | main | b22de96 |
| bluerock/NOVA/ | skylabs-proof | 220d4a8 |
| bluerock/bhv/ | skylabs-main | 20ba397 |
| fmdeps/brick-libcpp/ | main | 204cf18 |
| fmdeps/ci/ | main | 68178de |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | cfedfa4 |
| fmdeps/fm-tools/ | main | 6e85551 |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | e4c1411 |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 5ffc18c |
| vendored/rocq/ | skylabs-master | 6d192b5 |
| vendored/rocq-elpi/ | skylabs-master | e7c8227 |
| vendored/rocq-equations/ | skylabs-main | 737fdf9 |
| vendored/rocq-ext-lib/ | skylabs-master | 8172052 |
| vendored/rocq-iris/ | skylabs-master | 51c753a |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | 10bd9d7 |
| vendored/rocq-stdpp/ | skylabs-master | 8307c10 |
| fmdeps/skylabs-fm/ | main | 9de54e4 |
| vendored/vsrocq/ | skylabs-main | 39c9c5b |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 121503.0 | 121503.0 | -0.0 | total |
| -0.00% | 24210.1 | 24210.1 | -0.0 | ├ translation units |
| +0.00% | 97292.9 | 97292.9 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 121503.0 | 121503.0 | -0.0 | total |
| -0.00% | 24210.1 | 24210.1 | -0.0 | ├ translation units |
| +0.00% | 97292.9 | 97292.9 | +0.0 | └ proofs and tests |
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | f1faa4e |
| fmdeps/BRiCk/ | main | b62cb51 |
| fmdeps/auto/ | main | 2a53fc0 |
| fmdeps/auto-docs/ | main | b22de96 |
| bluerock/NOVA/ | skylabs-proof | 220d4a8 |
| bluerock/bhv/ | skylabs-main | 20ba397 |
| fmdeps/brick-libcpp/ | main | 204cf18 |
| fmdeps/ci/ | main | 68178de |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | cfedfa4 |
| fmdeps/fm-tools/ | main | 6e85551 |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | e4c1411 |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 5ffc18c |
| vendored/rocq/ | skylabs-master | 6d192b5 |
| vendored/rocq-elpi/ | skylabs-master | e7c8227 |
| vendored/rocq-equations/ | skylabs-main | 737fdf9 |
| vendored/rocq-ext-lib/ | skylabs-master | 8172052 |
| vendored/rocq-iris/ | skylabs-master | 51c753a |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | 10bd9d7 |
| vendored/rocq-stdpp/ | skylabs-master | 8307c10 |
| fmdeps/skylabs-fm/ | main | 9de54e4 |
| vendored/vsrocq/ | skylabs-main | 39c9c5b |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 121503.0 | 121503.0 | -0.0 | total |
| -0.00% | 24210.1 | 24210.1 | -0.0 | ├ translation units |
| +0.00% | 97292.9 | 97292.9 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 121503.0 | 121503.0 | -0.0 | total |
| -0.00% | 24210.1 | 24210.1 | -0.0 | ├ translation units |
| +0.00% | 97292.9 | 97292.9 | +0.0 | └ proofs and tests |
Contributor
Janno
approved these changes
Jan 26, 2026
Contributor
Janno
left a comment
Janno
left a comment
There was a problem hiding this comment.
Looks good. I'll rebase my branch on top of this one once it gets in.
jhaag-skylabs-ai
approved these changes
Jan 26, 2026
Contributor
Contributor
|
Sorry, I did not see the ping. I think it is fully subsumed by #125. |
Contributor
|
Closing (cf. Janno's note); feel free to reopen if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a module-level
build()function to thejson_goal.pytracer to enable explicit loading via the--tracerCLI argument.Problem
While
JsonGoalworks as the default tracer, users couldn't explicitly specify it using--tracer json_goal.py:JsonGoalbecause the loader would return the class itself rather than a properly wrappedTacticExtractorinstance. The code expects aTacticExtractorBuilderor an object with a.build()method that returns aTacticExtractor.Solution
Added a module-level
build()function that:BeforeAndAfter(JsonGoal())- matching the default tracer construction--tracer json_goal.py(module duck-typing viamodule.build())--tracer json_goal.py:build(explicit function loading)Changes
build()function torocq-pipeline/src/rocq_pipeline/tracers/json_goal.pyBeforeAndAfter[list[Any]]wrapping aJsonGoal()instanceTesting
Users can now explicitly specify the json_goal tracer:
uv run rat trace --tracer json_goal.py:build --task-file tasks.yamlor
uv run rat trace --tracer json_goal.py --task-file tasks.yamlBoth commands now work correctly and produce the same results as the default tracer behavior.