Skip to content

Update skript and skript-reflect versions in test workflow file.#4

Merged
sovdeeth merged 3 commits intoSkriptLang:mainfrom
devdinc:update-skript-to-solve-build-errors
Feb 6, 2026
Merged

Update skript and skript-reflect versions in test workflow file.#4
sovdeeth merged 3 commits intoSkriptLang:mainfrom
devdinc:update-skript-to-solve-build-errors

Conversation

@devdinc
Copy link
Contributor

@devdinc devdinc commented Jan 16, 2026

No description provided.

Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 2.14.0 and 2.6.2
does show how long this tool has gone without an update though lol

@devdinc
Copy link
Contributor Author

devdinc commented Jan 16, 2026

should be 2.14.0 and 2.6.2 does show how long this tool has gone without an update though lol

For some reason skript reflect 2.6.2 does not work, keep saying "2.14.0 is a nightly version and skript-reflect supports 2.14.0 and above", you can checkout skript-reflect repository for the workflow run, haven't really looked into it.

And you are right regarding, this tool being heavily outdated, that's why I'm kinda creating a runtime test framework with parity with this one. check it out in devdinc/skripts

@devdinc devdinc requested a review from sovdeeth January 16, 2026 19:03
@sovdeeth
Copy link
Member

That run was from before 2.14.0 was released

@devdinc
Copy link
Contributor Author

devdinc commented Jan 16, 2026

That run was from before 2.14.0 was released

Well, when I did it on my own got the same error.

@sovdeeth
Copy link
Member

I'll take a look at it later, but it's likely an issue with reflect. Test-action should be testing with the latest versions.

@devdinc
Copy link
Contributor Author

devdinc commented Jan 16, 2026

I'll take a look at it later, but it's likely an issue with reflect. Test-action should be testing with the latest versions.

Alright, I have created a seperate branch with those versions, https://github.com/devdinc/skript-test-action/actions/runs/21077819238/job/60624042926 , if it does not error I'll update the PR.

Yep https://github.com/devdinc/skript-test-action/actions/runs/21077819238/job/60624042926#step:11:554 still errors.

@devdinc
Copy link
Contributor Author

devdinc commented Jan 16, 2026

@sovdeeth the sk-reflection problem seems to stem from quickTest producing postfix nightly, and since post fix is compared lexigeraphly or however its spelled, pre1 comes bigger than a stable version ("p" > "n"). And sk-reflect uses Version("2.14.0-pre1") to check if the version matches.

To solve this issue, either:

  • I can create a quickTestRelease test task with a new modifier in build.gradle that causes it to use dependson githubRelease.
  • I can change already existing quickTest to use dependson githubRelease, with a new modifier.
  • Change how postfix is compared(IDK what I will do, best option seems to compare commit hashes, but complicated logic)
  • On skript reflect simply use 2.14.0 instead of ...pre1 to compare

What are your thoughts?

@sovdeeth
Copy link
Member

yeah we'll just update skript reflect's build.gradle

@sovdeeth sovdeeth merged commit 45a7b35 into SkriptLang:main Feb 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants