Backport: V3 - Throw explicit InvalidImageContentException when BMP BPP is invalid.#3068
Open
JimBobSquarePants wants to merge 4 commits intorelease/3.1.xfrom
Open
Backport: V3 - Throw explicit InvalidImageContentException when BMP BPP is invalid.#3068JimBobSquarePants wants to merge 4 commits intorelease/3.1.xfrom
JimBobSquarePants wants to merge 4 commits intorelease/3.1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This pull request improves the robustness of the BMP decoder by adding stricter validation for the
bitsPerPixelfield and introducing a corresponding unit test. The main change ensures that invalid or unsupportedbitsPerPixelvalues are properly detected and handled, preventing potential errors when decoding malformed BMP files.Validation improvements in BMP decoding:
Decodemethod inBmpDecoderCore.csto use a localbitsPerPixelvariable for clarity and consistency throughout the code.Decodeto throw anInvalidImageContentExceptionwhenbitsPerPixelis not in the supported range (>0 and <=8, 16, 24, 32), preventing decoding of invalid BMP files.Testing enhancements:
BmpDecoder_ThrowsException_Issue3067inBmpDecoderTests.csto verify that decoding a BMP file withbitsPerPixel = 0correctly throws anInvalidImageContentException.