Skip to content

fix(react): fallback to default export when variant named export not … #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rikaweb wants to merge 1 commit into from
Closed

fix(react): fallback to default export when variant named export not … #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions packages/react/src/components/Placeholder/placeholder-utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,15 +251,22 @@ export const getComponentForRendering = (
// Render SXA Rendering Variant if available
const exportName = renderingDefinition.params?.FieldNames;

const renderedComponent =
// Try to find a named export matching the variant, otherwise fallback to default export
const variantComponent =
exportName && exportName !== DEFAULT_EXPORT_NAME
? ((component as ReactModule)[exportName] as ComponentType)
: (component as ReactModule).default ||
(component as ReactModule).Default ||
(component as ComponentType);
: undefined;

const defaultComponent =
(component as ReactModule).default ||
(component as ReactModule).Default ||
(component as ComponentType);

// Use variant if found, otherwise fallback to default export
const renderedComponent = variantComponent || defaultComponent;

if (!renderedComponent) {
logUnknownComponentError(exportName !== DEFAULT_EXPORT_NAME ? exportName : undefined);
logUnknownComponentError();

return {
component: missingComponentComponent ?? MissingComponent,
Expand Down