Skip to content

<sc-editingscripts /> nullreference #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robearlam merged 2 commits into from
Jan 11, 2026
Merged

<sc-editingscripts /> nullreference #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58288bc
<sc-editingscripts /> nullreference
IvanLieckens Jan 9, 2026
9235a1e
Fixed Unit tests
IvanLieckens Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Sitecore.AspNetCore.SDK.Pages/TagHelpers/EditingScriptsTagHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,12 @@ public class EditingScriptsTagHelper : TagHelper
/// <inheritdoc />
public override void Process(TagHelperContext context, TagHelperOutput output)
{
ISitecoreRenderingContext renderingContext = ViewContext?.HttpContext.GetSitecoreRenderingContext() ??
throw new NullReferenceException(Resources.Exception_EditingScriptsTagHelperSitecoreRenderingContextNull);
ISitecoreRenderingContext? renderingContext = ViewContext?.HttpContext.GetSitecoreRenderingContext();

output.TagName = string.Empty;
string html = string.Empty;

if (renderingContext.Response?.Content?.Sitecore?.Context?.IsEditing ?? false)
if (renderingContext?.Response?.Content?.Sitecore?.Context?.IsEditing ?? false)
{
EditingContext? editingContext = JsonSerializer.Deserialize<EditingContext>(renderingContext.Response?.Content.ContextRawData ?? string.Empty);
if (editingContext == null)
Expand Down
6 changes: 3 additions & 3 deletions tests/Sitecore.AspNetCore.SDK.Pages.Tests/TagHelpers/EditingScriptsTagHelperFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public void Ctor_InvalidArgs_Throws(GuardClauseAssertion guard)

[Theory]
[AutoNSubstituteData]
public async Task ProcessAsync_NoSitecoreContenxt_ExceptionIsThrown(EditingScriptsTagHelper sut, TagHelperContext tagHelperContext, TagHelperOutput tagHelperOutput)
public async Task ProcessAsync_NoSitecoreContext_EmptyResult(EditingScriptsTagHelper sut, TagHelperContext tagHelperContext, TagHelperOutput tagHelperOutput)
{
// Arrange
ViewContext viewContext = new()
Expand All @@ -66,10 +66,10 @@ public async Task ProcessAsync_NoSitecoreContenxt_ExceptionIsThrown(EditingScrip
sut.ViewContext = viewContext;

// Act
Func<Task> act = async () => await sut.ProcessAsync(tagHelperContext, tagHelperOutput);
await sut.ProcessAsync(tagHelperContext, tagHelperOutput);

// Assert
await act.Should().ThrowAsync<NullReferenceException>();
tagHelperOutput.Content.GetContent().Should().BeEmpty();
}

[Theory]
Expand Down
Loading