Skip to content

Fix settings UI initializing with wrong values #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxTCodes merged 1 commit into from
Feb 10, 2026
Merged

Fix settings UI initializing with wrong values #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions source.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ local function loadSettings()
]]
end


if file then
local success, decodedFile = pcall(function() return HttpService:JSONDecode(file) end)
if success then
Expand All @@ -166,7 +165,7 @@ local function loadSettings()
return
end

if file ~= {} then
if #file > 0 then
for categoryName, settingCategory in pairs(settingsTable) do
if file[categoryName] then
for settingName, setting in pairs(settingCategory) do
Expand All @@ -177,6 +176,17 @@ local function loadSettings()
end
end
end
-- If no settings saved, apply overridden settings only
else
for settingName, settingValue in overriddenSettings do
local split = string.split(settingName, ".")
assert(#split == 2, "Rayfield | Invalid overridden setting name: " .. settingName)
local categoryName = split[1]
local settingNameOnly = split[2]
if settingsTable[categoryName] and settingsTable[categoryName][settingNameOnly] then
settingsTable[categoryName][settingNameOnly].Element:Set(settingValue)
end
end
end
settingsInitialized = true
end)
Expand Down