Skip to content

Prefer getOfflinePlayerIfCached over iteration #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Peashooter101 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prefer getOfflinePlayerIfCached over iteration #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e329b8
Prefer getOfflinePlayerIfCached over iteration
Peashooter101 May 11, 2026
c717d61
Add format reset to nick.set.self message, fixes #11
Peashooter101 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/main/java/simplexity/simplenicks/commands/arguments/OfflinePlayerArgument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,8 @@ public class OfflinePlayerArgument implements CustomArgumentType<OfflinePlayer,
@Override
public @NotNull OfflinePlayer parse(@NotNull StringReader reader) throws CommandSyntaxException {
String playerName = reader.readString();
for (Player player : Bukkit.getOnlinePlayers()) {
if (player.getName().equalsIgnoreCase(playerName)) return player;
}
for (OfflinePlayer player : Bukkit.getOfflinePlayers()) {
if (player.getName() == null || player.getName().isEmpty()) continue;
if (player.getName().equalsIgnoreCase(playerName)) return player;
}
OfflinePlayer player = Bukkit.getOfflinePlayerIfCached(playerName);
if (player != null) return player;
throw Exceptions.INVALID_PLAYER_SPECIFIED.create(playerName);
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/simplexity/simplenicks/config/LocaleMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public enum LocaleMessage {
SERVER_DISPLAY_NAME("plugin.server-display-name", "<gray>[Server]</gray>"),

// Basic Functionality
SET_SELF("nick.set.self", "<green>Changed your nickname to <value><green>!"),
SET_SELF("nick.set.self", "<green>Changed your nickname to <reset><value><green>!"),
SET_TARGET("nick.set.target", "<green>Changed <target>'s nickname to <value>"),
SET_BY_INITIATOR("nick.set.by-initiator", "<green><initiator> changed your nickname to <reset><value><green>!"),
RESET_SELF("nick.reset.self", "<green>Reset your nickname!"),
Expand Down