docs: Remove sphinx monkey-patching#630
Closed
ValerianRey wants to merge 2 commits into
Closed
Conversation
ValerianRey
added
the
cc: docs
ValerianRey
added
the
cc: docs
github-actions
Bot
changed the title
Member
Author
|
Closing this, as it doesn't seem that my sphinx fix will be merged anytime soon. Sphinx seems to be under minimal maintenance only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be merged whenever the
emphasize-linesoption is added to thetestcodedirective ofsphinx.ext.doctestdirective, if sphinx-doc/sphinx#14335 is accepted.If that's the case and a new version of sphinx is released, we will also have to update the lower cap of sphinx in the doc dependencies. Lastly, we will be able to add captions and names (for references) to the code examples, so we may open new PRs to improve the appearance of the code examples in TorchJD.