Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7da3dff7d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Fixes build failures when recursively building galleries that include directories without any media files (resulting in an empty headerImage), and updates related theme-path resolution + package versions.
Changes:
- Skip social media card generation + header optimization when
galleryData.headerImageis empty. - Adjust sub-gallery thumbnail path resolution to use resolved subgallery paths and AVIF thumbnail naming.
- Bump package versions to
2.1.4across workspace packages / lockfile.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
gallery/src/modules/build/index.ts |
Guards header/social-card generation when headerImage is empty; adjusts metadata image assignment condition. |
common/src/theme/resolver.ts |
Reuses a computed resolvedPath and passes it into subgallery thumbnail path helper. |
common/src/theme/paths.ts |
Updates subgallery thumbnail path construction (AVIF name + gallery/images location) and adds support for resolved subgallery path. |
gallery/package.json |
Bumps CLI package + workspace dependency versions to 2.1.4. |
common/package.json |
Bumps common package version to 2.1.4. |
themes/modern/package.json |
Bumps theme version and common dependency to 2.1.4. |
gallery/src/modules/create-theme/templates/base/package.json |
Updates @simple-photo-gallery/common peer dependency range to ^2.1.4. |
yarn.lock |
Updates lockfile entries for 2.1.4 versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5724b7fef1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This PR fixes failures of the
buildscript when the user has a recursive folder structure, but one of the folders is empty. The issue was that the script tries to generate the header image, which doesn't exist.Fixes #138