Skip to content

[3.0] Bots - reduce session writes #9152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sbulen wants to merge 3 commits into
base: release-3.0
Choose a base branch
from
Draft

[3.0] Bots - reduce session writes #9152

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83955ed
Minimize unnecessary session writes
sbulen Mar 15, 2026
6821fcf
Minimize unnecessary session writes
sbulen Mar 15, 2026
e7e1d5b
Minimize unnecessary session writes
sbulen Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Sources/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,20 @@ public function read(string $session_id): string
*/
public function write(string $session_id, string $data): bool
{
// Any action that is not dependent on data within the session may be added to this array
static $no_writes = ['dlattach'];

// Don't bother writing the session if cookies are disabled
if (empty($_COOKIE)) {
return true;
}

// Don't bother writing the session for users just browsing
// If verification is required, always write the session
if ((empty($_REQUEST['action']) || \in_array($_REQUEST['action'], $no_writes, true)) && !empty(Config::$scripturl) && empty(Utils::$context['require_verification'])) {
return true;
}

if (preg_match('~^[A-Za-z0-9,-]{16,64}$~', $session_id) == 0) {
return false;
}
Expand Down
Loading