Conversation
The tests were changed to launch with the python executable and run in the comment_spell_check subdir.
zivy
left a comment
There was a problem hiding this comment.
These changes look OK, but the testing approach using subprocess is less standard and should be changed. Usually the entry point method to the script is defined as a regular function, like here and then invoked when the script is run. This allows for passing arguments to the method for debugging and more standard usage of pytest with the pytest.mark.parametrize fixture, like here. This would change the current pytest code from multiple independent tests to a single tests with multiple parameterizations and no calls to subprocess.
Yeah, I did it that way in my dicom2stl repo, and at some point it'll probably change it here too. That's just more work that I'm putting off for now. This is older code that I'm gradually improving. |
The tests were changed to launch with the python executable and run in the comment_spell_check subdir.