Skip to content
This repository was archived by the owner on Feb 18, 2018. It is now read-only.

Use mri-stack from TestImages. Fixes #40#41

Open
timholy wants to merge 1 commit intoSimonDanisch:masterfrom
timholy:pull-request/7519a7a8
Open

Use mri-stack from TestImages. Fixes #40#41
timholy wants to merge 1 commit intoSimonDanisch:masterfrom
timholy:pull-request/7519a7a8

Conversation

@timholy
Copy link

@timholy timholy commented Feb 26, 2017

Requires JuliaImages/TestImages.jl#29 and JuliaGL/GLVisualize.jl#143. The new file is quite small, so the resolution isn't impressive, but on the other hand the anisotropic pixel spacing represents a good test of functionality that's crucial for almost anyone doing volumetric visualization.

@timholy
Copy link
Author

timholy commented Mar 30, 2017

This can be closed, right?

vol = testimage("mri-stack")
end

window = GLPlot.init()
Copy link

@AShedko AShedko Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently no such method. Shouldn't it be
window = createdisplay()?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're probably on an old version. Try Pkg.checkout("GLPlot")

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that helped. although i still does not display the projections, just the 3d view

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What projections?

@SimonDanisch
Copy link
Owner

Or merged?

@timholy
Copy link
Author

timholy commented Jun 7, 2017

I don't think there's anything important here anymore...the main problem this was designed to solve was the fact that the original example referred to a file on your harddrive, and I was trying to use a publicly-available dataset. You replaced this file with one where you synthesize a 3d dataset, and in some ways that's nicer because you have complete control over resolution, etc. So perhaps the only reason to use this is if you want users looking at a "real image" rather than a synthetic one.

One other point worth making is that "mri-stack" has very poor resolution along the z axis, and it's 5x different from the resolution in x and y. That might be useful in terms of making sure that your display algorithms handle anisotropic images correctly; on the other hand, it looks really crappy if the user rotates the sample so that the z-axis is nearly in-plane.

@timholy
Copy link
Author

timholy commented Jun 7, 2017

Let me know what you want to do; if you decide you want this (perhaps as a second volume example), I'd be very happy to contribute it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants