Skip to content

fix: i2c value check #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mateusz-Krajewski merged 2 commits into from
May 30, 2026
Merged

fix: i2c value check #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea3620f
fix: i2c value check
KrzysKond May 30, 2026
0d29f38
fix lint
KrzysKond May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mw/i2c_service/controller/ads7828/controller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ std::optional<uint16_t> ADS7828::GetAdcRawRead(const uint8_t& channel) const {
if (!res.has_value()) {
return std::nullopt;
}
if (res.value().size() != 2) {
return std::nullopt;
}
uint16_t data = ((res.value()[0]) << 8);
data |= res.value()[1];
return data;
Expand Down
3 changes: 3 additions & 0 deletions mw/i2c_service/tests/test_ads7828.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ std::tuple<uint8_t, std::optional<std::vector<uint8_t>>, std::optional<uint16_t>
// tuple<channel, i2cWriteReadMockRes, expectedRawRead, expectedVoltage>
INSTANTIATE_TEST_SUITE_P(GetAdcRawReadandVoltageTestParams, GetAdcRawReadandVoltageTest, ::testing::Values(
std::make_tuple(0, std::optional<std::vector<uint8_t>>{}, std::optional<uint16_t>{}, std::optional<float>{}),
// EOF from i2c_service (empty vector): must not crash
std::make_tuple(0, std::optional<std::vector<uint8_t>>{std::vector<uint8_t>{}},
std::optional<uint16_t>{}, std::optional<float>{}),
std::make_tuple(1, std::optional<std::vector<uint8_t>>{{0, 1}}, std::optional<uint16_t>{1},
std::optional<float>{0.000805664051}),
std::make_tuple(2, std::optional<std::vector<uint8_t>>{{1, 1}}, std::optional<uint16_t>{257},
Expand Down
Loading