feat: add logger service for flight computer by KrzysKond · Pull Request #352 · Simba-Avionic/srp

KrzysKond · 2026-04-19T19:01:33Z

Logger for FC

Mateusz-Krajewski

Wygląda ok, po testach zmienie na Approve

Mateusz-Krajewski · 2026-04-20T09:13:14Z

+std::string Data_t::get_header() {
+  return kCsvHeader;
+}


Suggested change

std::string Data_t::get_header() {

return kCsvHeader;

}

std::string Data_t::get_header() const noexcept {

return kCsvHeader;

}

Mateusz-Krajewski · 2026-04-20T09:14:32Z

+namespace {
+constexpr auto kCsvHeader =
+    "TIMESTAMP;BOARD_TEMP1;BOARD_TEMP2;BOARD_TEMP3;BME_TEMP;BME_HUMIDITY;"
+    "BME_ALTITUDE;CPU_USAGE;MEM_USAGE;DISK_UTILIZATION";
+}


Suggested change

namespace {

constexpr auto kCsvHeader =

"TIMESTAMP;BOARD_TEMP1;BOARD_TEMP2;BOARD_TEMP3;BME_TEMP;BME_HUMIDITY;"

"BME_ALTITUDE;CPU_USAGE;MEM_USAGE;DISK_UTILIZATION";

}

namespace {

constexpr auto kCsvdecimalPrecision = 2;

constexpr auto kCsvHeader =

"TIMESTAMP;BOARD_TEMP1;BOARD_TEMP2;BOARD_TEMP3;BME_TEMP;BME_HUMIDITY;"

"BME_ALTITUDE;CPU_USAGE;MEM_USAGE;DISK_UTILIZATION";

}

Mateusz-Krajewski · 2026-04-20T09:14:42Z

+  res << mem_usage_ << ";";
+  res << disk_utilization_;
+  return res.str();
+}


Suggested change

}

std::string Data_t::to_string(const std::string& timestamp) const {

std::stringstream res;

res << std::fixed << std::setprecision(kCsvdecimalPrecision);

res << timestamp << ";";

std::shared_lock<std::shared_mutex> lock(mutex_);

res << board_temp1_ << ";";

res << board_temp2_ << ";";

res << board_temp3_ << ";";

res << bme_temp_ << ";";

res << bme_humidity_ << ";";

res << bme_altitude_ << ";";

res << cpu_usage_ << ";";

res << mem_usage_ << ";";

res << disk_utilization_;

return res.str();

}

Mateusz-Krajewski · 2026-04-20T09:15:23Z

+#define APPS_FC_LOGGER_SERVICE_DATA_TYPE_HPP_
+
+#include <cstdint>
+#include <mutex>  // NOLINT


Suggested change

#include <mutex> // NOLINT

Mateusz-Krajewski · 2026-04-20T09:16:12Z

+namespace {
+constexpr auto kLoggerFilename = "_fc_log.csv";
+constexpr auto kLoggerFilenamePrefix = "/home/root/";
+constexpr std::uint16_t kSaveIntervalMs = 5000;
+constexpr auto kEnvServicePathName = "srp/env/EnvAppFc/envServiceFc_ipc";
+constexpr auto kUdpServicePathName = "srp/apps/FcFileLoggerApp/logService_udp";
+constexpr auto kIpcServicePathName = "srp/apps/FcFileLoggerApp/logService_ipc";
+constexpr auto kSysStatServicePathName = "srp/apps/FcSysStatService/FcSysStatService_ipc";
+constexpr auto kFileDidPathName = "/srp/apps/FcFileLoggerApp/logger_did";
+constexpr std::uint8_t kLogsOn = 1;
+constexpr std::uint8_t kLogsOff = 0;
+}  // namespace


Suggested change

namespace {

constexpr auto kLoggerFilename = "_fc_log.csv";

constexpr auto kLoggerFilenamePrefix = "/home/root/";

constexpr std::uint16_t kSaveIntervalMs = 5000;

constexpr auto kEnvServicePathName = "srp/env/EnvAppFc/envServiceFc_ipc";

constexpr auto kUdpServicePathName = "srp/apps/FcFileLoggerApp/logService_udp";

constexpr auto kIpcServicePathName = "srp/apps/FcFileLoggerApp/logService_ipc";

constexpr auto kSysStatServicePathName = "srp/apps/FcSysStatService/FcSysStatService_ipc";

constexpr auto kFileDidPathName = "/srp/apps/FcFileLoggerApp/logger_did";

constexpr std::uint8_t kLogsOn = 1;

constexpr std::uint8_t kLogsOff = 0;

} // namespace

namespace {

constexpr auto kEnvServicePathName = "srp/env/EnvAppFc/envServiceFc_ipc";

constexpr auto kUdpServicePathName = "srp/apps/FcFileLoggerApp/logService_udp";

constexpr auto kIpcServicePathName = "srp/apps/FcFileLoggerApp/logService_ipc";

constexpr auto kSysStatServicePathName = "srp/apps/FcSysStatService/FcSysStatService_ipc";

constexpr auto kFileDidPathName = "/srp/apps/FcFileLoggerApp/logger_did";

constexpr std::uint8_t kLogsOn = 1;

constexpr std::uint8_t kLogsOff = 0;

constexpr auto kLoggerFilename = "_fc_log.csv";

constexpr auto kLoggerFilenamePrefix = "/home/root/";

constexpr std::uint16_t kSaveIntervalMs = 50;

} // namespace

Mateusz-Krajewski · 2026-04-20T09:17:08Z

+  logger_did_->Offer();
+  service_ipc_->StartOffer();
+  service_udp_->StartOffer();
+  SomeIpInit();


Suggested change

logger_did_->Offer();

service_ipc_->StartOffer();

service_udp_->StartOffer();

SomeIpInit();

SomeIpInit();

logger_did_->Offer();

service_ipc_->StartOffer();

service_udp_->StartOffer();

Mateusz-Krajewski · 2026-04-20T09:20:13Z

+        auto res = stat_service_handler_->NewSystemUsage.GetNewSamples();
+        if (!res.HasValue()) {
+          return;
+        }
+        data_.SetCpuUsage(res.Value().cpu_usage);
+        data_.SetMemUsage(res.Value().mem_usage);
+        data_.SetDiskUtilization(res.Value().disk_utilization);


note: mogłeś sobie skrócić kod robiąc metodę SetSystemStat

to wsm istotne jest, bo jak kompilator nie ogarnie to blokujesz mutex 3 razy (co trochę trwa), i miedzy blokowaniami mogą ci się inne eventy wbijac (aczkolwiem nwm czy nie skopiowales tego z loger-ec)

Mateusz-Krajewski · 2026-04-20T09:21:15Z

+    env_service_handler_->newBoardTempEvent_1.Subscribe(1, [this](std::uint8_t /*status*/) {
+      env_service_handler_->newBoardTempEvent_1.SetReceiveHandler([this]() {
+        auto res = env_service_handler_->newBoardTempEvent_1.GetNewSamples();
+        if (res.HasValue()) {
+          data_.SetBoardTemp1(res.Value());
+        }
+      });
+    });
+
+    env_service_handler_->newBoardTempEvent_2.Subscribe(1, [this](std::uint8_t /*status*/) {
+      env_service_handler_->newBoardTempEvent_2.SetReceiveHandler([this]() {
+        auto res = env_service_handler_->newBoardTempEvent_2.GetNewSamples();
+        if (res.HasValue()) {
+          data_.SetBoardTemp2(res.Value());
+        }
+      });
+    });
+
+    env_service_handler_->newBoardTempEvent_3.Subscribe(1, [this](std::uint8_t /*status*/) {
+      env_service_handler_->newBoardTempEvent_3.SetReceiveHandler([this]() {
+        auto res = env_service_handler_->newBoardTempEvent_3.GetNewSamples();
+        if (res.HasValue()) {
+          data_.SetBoardTemp3(res.Value());
+        }
+      });
+    });


teoretycznie to samo, metoda SetBoardTemp(const int16_t& value, const TempSensor_e sensor)

Mateusz-Krajewski · 2026-04-20T09:21:21Z

+    env_service_handler_->newBME280Event.Subscribe(1, [this](std::uint8_t /*status*/) {
+      env_service_handler_->newBME280Event.SetReceiveHandler([this]() {
+        auto res = env_service_handler_->newBME280Event.GetNewSamples();
+        if (!res.HasValue()) {
+          return;
+        }
+        data_.SetBmeTemp(res.Value().temperature);
+        data_.SetBmeHumidity(res.Value().humidity);
+        data_.SetBmeAltitude(res.Value().altitude);
+      });


Mateusz-Krajewski · 2026-04-23T09:16:58Z

+      });
+    });
+
+    env_service_handler_->newBoardTempEvent_3.Subscribe(1, [this](std::uint8_t /*status*/) {


Suggested change

env_service_handler_->newBoardTempEvent_3.Subscribe(1, [this](std::uint8_t /*status*/) {

env_service_handler_->newBoardTempEvent_3.Subscribe(1, [this](std::uint8_t status) {

dlaczego te statusy są zakomentowane? + brak logowania

* feat: dd logger service for flight computer * feat: add forgotten deployment files * fix: remove include chrono * update SD * feat: add svc over UDP * fix --------- Co-authored-by: Mateusz Krajewski <matikrajek42@gmail.com>

KrzysKond added 2 commits April 19, 2026 20:56

feat: dd logger service for flight computer

a4956ca

feat: add forgotten deployment files

6ea364c

KrzysKond requested a review from Mateusz-Krajewski April 19, 2026 19:01

KrzysKond added 2 commits April 19, 2026 21:13

fix: remove include chrono

7a4cb2e

update SD

4c8c07d

KrzysKond self-assigned this Apr 19, 2026

feat: add svc over UDP

b3b877d

KrzysKond mentioned this pull request Apr 19, 2026

Add FC Logger App #338

Closed

Mateusz-Krajewski linked an issue Apr 20, 2026 that may be closed by this pull request

Add FC Logger App #338

Closed

Mateusz-Krajewski reviewed Apr 20, 2026

View reviewed changes

Mateusz-Krajewski reviewed Apr 23, 2026

View reviewed changes

fix

15951c5

Mateusz-Krajewski merged commit 16fc13a into master Apr 27, 2026
2 checks passed

Mateusz-Krajewski deleted the loger-fc branch April 27, 2026 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add logger service for flight computer#352

feat: add logger service for flight computer#352
Mateusz-Krajewski merged 6 commits into
masterfrom
loger-fc

KrzysKond commented Apr 19, 2026 •

edited

Loading

Uh oh!

Mateusz-Krajewski left a comment

Uh oh!

Mateusz-Krajewski Apr 20, 2026

Uh oh!

Mateusz-Krajewski Apr 20, 2026

Uh oh!

Mateusz-Krajewski Apr 20, 2026

Uh oh!

Mateusz-Krajewski Apr 20, 2026

Uh oh!

Mateusz-Krajewski Apr 20, 2026

Uh oh!

Mateusz-Krajewski Apr 20, 2026

Uh oh!

Mateusz-Krajewski Apr 20, 2026

Uh oh!

Mateusz-Krajewski Apr 23, 2026

Uh oh!

Mateusz-Krajewski Apr 20, 2026

Uh oh!

Mateusz-Krajewski Apr 20, 2026

Uh oh!

Mateusz-Krajewski Apr 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-}
+std::string Data_t::to_string(const std::string& timestamp) const {
+  std::stringstream res;
+  res << std::fixed << std::setprecision(kCsvdecimalPrecision);
+  res << timestamp << ";";
+  std::shared_lock<std::shared_mutex> lock(mutex_);
+  res << board_temp1_ << ";";
+  res << board_temp2_ << ";";
+  res << board_temp3_ << ";";
+  res << bme_temp_ << ";";
+  res << bme_humidity_ << ";";
+  res << bme_altitude_ << ";";
+  res << cpu_usage_ << ";";
+  res << mem_usage_ << ";";
+  res << disk_utilization_;
+  return res.str();
+}

	env_service_handler_->newBoardTempEvent_3.Subscribe(1, [this](std::uint8_t /status/) {
	env_service_handler_->newBoardTempEvent_3.Subscribe(1, [this](std::uint8_t status) {

Conversation

KrzysKond commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mateusz-Krajewski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KrzysKond commented Apr 19, 2026 •

edited

Loading