Skip to content

Implement GetListMetaData#24

Open
rkovarik wants to merge 2 commits intoSilverpop:masterfrom
rkovarik:Issue21
Open

Implement GetListMetaData#24
rkovarik wants to merge 2 commits intoSilverpop:masterfrom
rkovarik:Issue21

Conversation

@rkovarik
Copy link
Contributor

@rkovarik rkovarik commented Sep 7, 2015

No description provided.

@rkovarik rkovarik changed the title #21 Implement GetListMetaData, add type and defaultValue to Column Implement GetListMetaData, add type and defaultValue to Column Sep 9, 2015
@larrychu-acoustic
Copy link

larrychu-acoustic commented Sep 10, 2015

Hello rkovarik. Thank you for the pull request. Did you mean to include the copyright notice in the submitted code?

@rkovarik
- remove accidentallt commited copyrights
c893a00 
- move result class to the correct package
- add support for selection values for checkboxes and radio fields
- remove new fields from Column element, use custom column instead
@rkovarik
Copy link
Contributor Author

rkovarik commented Sep 11, 2015

Thx for review, fixed and improved on the branch Issue24.

@rkovarik rkovarik changed the title Implement GetListMetaData, add type and defaultValue to Column Implement GetListMetaData Sep 11, 2015
@ChrisCurtin
Copy link
Contributor

ChrisCurtin commented Nov 4, 2015

Hi Rovarik,

Looks like we were both working on this command. Can you check against the develop branch and see if our implementation meets your needs?

Thanks

Chris

@ChrisCurtin
Copy link
Contributor

ChrisCurtin commented Dec 20, 2016

Hi Rovarik,

Looks like we were both working on this command. Can you check against the develop branch and see if our implementation meets your needs?

Thanks

Chris

@rkovarik
Copy link
Contributor Author

rkovarik commented Dec 20, 2016

Hi Chris,

we are using our fork with this implementation https://github.com/rkovarik/engage-api-client/blob/master/src/main/java/com/silverpop/api/client/command/GetListMetaDataCommand.java

Unfortunately we can't invest time to get into sync with the origin because of the API changes which were made there.

Roman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rkovarik @larrychu-acoustic @ChrisCurtin