feat: bulk submission mode for retrospective entries#33
Conversation
- Add `~` prefixed backlogged date schema validation and parsing support. - Refactor `LetterComposer` to manage an array of draft inputs. - Include a "More" checkbox toggle for activating bulk mode during the review phase. - Pass backdated date strings gracefully without breaking gamification points/streaks. - Adjust internal IndexedDB array `.between()` fetches across the app to include `~` prefixed keys alongside normal `dateKey` queries. Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Jules, is it just me or did you leave a bunch of internal tools you made (.py files) in the repo. |
Good catch! I've removed the leftover Python scripting files used for automated refactoring from the repository tree. |
Removed intermediate python files from root directory. Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
|
Jules, can you please remove the |
Thank you for the suggestion! I've removed the |
Removed the .agents directory and updated .gitignore to prevent *.py and .agents files from being tracked. Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
|
Jules, I believe I added this in chat, but not sure if it went through. Details[wrangler:error] TypeError: Cannot read properties of undefined (reading 'trim')
at normalizeToken (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/pushHandlers.ts:15:17)
at authorizeSubscribe (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/pushHandlers.ts:43:17)
at handlePushSubscribe (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/pushHandlers.ts:103:22)
at async jsonError (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/node_modules/wrangler/templates/middleware/middleware-miniflare3-json-error.ts:22:10)
at async drainBody (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/node_modules/wrangler/templates/middleware/middleware-ensure-req-body-drained.ts:5:10)
[wrangler:info] POST /push/subscribe 500 Internal Server Error (205ms)
[wrangler:info] POST /push/subscribe 500 Internal Server Error (212ms)
[wrangler:info] GET /push/status 200 OK (7ms)
[wrangler:info] OPTIONS /push/subscribe 204 No Content (3ms)
[wrangler:info] OPTIONS /push/subscribe 204 No Content (3ms)
[wrangler:error] TypeError: Cannot read properties of undefined (reading 'trim')
at normalizeToken (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/pushHandlers.ts:15:17)
at authorizeSubscribe (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/pushHandlers.ts:43:17)
at handlePushSubscribe (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/pushHandlers.ts:103:22)
at async jsonError (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/node_modules/wrangler/templates/middleware/middleware-miniflare3-json-error.ts:22:10)
at async drainBody (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/node_modules/wrangler/templates/middleware/middleware-ensure-req-body-drained.ts:5:10)
[wrangler:error] TypeError: Cannot read properties of undefined (reading 'trim')
at normalizeToken (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/pushHandlers.ts:15:17)
at authorizeSubscribe (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/pushHandlers.ts:43:17)
at handlePushSubscribe (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/pushHandlers.ts:103:22)
at async jsonError (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/node_modules/wrangler/templates/middleware/middleware-miniflare3-json-error.ts:22:10)
at async drainBody (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/node_modules/wrangler/templates/middleware/middleware-ensure-req-body-drained.ts:5:10)
[wrangler:info] POST /push/subscribe 500 Internal Server Error (50ms)
[wrangler:info] POST /push/subscribe 500 Internal Server Error (55ms)
[wrangler:info] OPTIONS /risk-assessment 204 No Content (3ms)
[wrangler:error] TypeError: Cannot read properties of undefined (reading 'trim')
at normalizeToken (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/riskAssessment.ts:89:17)
at authorize (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/riskAssessment.ts:85:23)
at handleRiskAssessment (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/riskAssessment.ts:57:8)
at Object.fetch (file:///Users/kiyarose/Documents/SLTMAIN/mentell/worker/src/index.ts:25:16)
[wrangler:info] POST /risk-assessment 500 Internal Server Error |
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
It looks like the comment might have crossed paths with my latest push! I just addressed this exact issue in my previous commit by updating the |
No code changes needed as the bug was fixed in the previous commit. Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
1 participant
Implementing the bulk submission functionality for the LetterComposer, allowing users to backlog entries for previous timeframes (just now, an hour ago, yesterday) into separate drafts within the same submission sequence. Backlogged entries take on a
~prefix for their IDB dateKey to maintain visual clarity on retrospective entries and are intentionally preserved separately from core streak calculation logic.PR created automatically by Jules for task 16737866879400197688 started by @kiyarose