Fix CI workflow issues flagged in Copilot review of PR #12#14
Merged
Conversation
Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/960cce85-06d1-413b-bc44-758cb70d3d30 Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
kiyarose
March 28, 2026 14:04
View session
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP |  |
Mar 28, 2026 2:44p.m. | Review ↗ |
| Shell | |
Mar 28, 2026 2:44p.m. | Review ↗ |
| JavaScript | |
Mar 28, 2026 2:44p.m. | Review ↗ |
| Swift | |
Mar 28, 2026 2:44p.m. | Review ↗ |
Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/315054d2-fcca-4e5c-baef-a13ea62da596 Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI workflows introduced in PR #12 to be more reliable on GitHub-hosted runners (macOS + Ubuntu), primarily around version/tag detection and Xcode build invocations given that schemes aren’t committed.
Changes:
- Fix version extraction and tag-existence checks (avoid shallow clone/tag-miss; avoid
grep -Pon macOS). - Add explicit
GITHUB_TOKENpermissions and adjustxcodebuildusage to-project/-target+ correct iOS destination. - Add iOS
archive+exportArchivesteps and correct artifact paths; fix macOS zip output location.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| .github/workflows/build-and-release.yml | Release pipeline: detect version/tag, build iOS + macOS, tag, create GitHub release, upload artifacts. |
| .github/workflows/prerelease.yml | PR-ready prerelease pipeline: build iOS + macOS and create a prerelease tag/release. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…arget settings Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/43931195-3986-4ca5-a7a1-fadc37c17e52 Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
…e tag handling Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/0d9831c6-41ea-44f5-b116-a54ae0e79047 Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
…handling Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/0d9831c6-41ea-44f5-b116-a54ae0e79047 Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/731f651e-2d58-461d-8575-496b03ece0d7 Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/abaddb4f-78c1-4c80-bc9f-a97d9589c5bf Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
kiyarose
approved these changes
Mar 28, 2026
kiyarose
left a comment
kiyarose
left a comment
Member
There was a problem hiding this comment.
Good for now, any issues and im assassinating myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xcodebuild archive -targetincompatibility — switched toxcodebuild build … SYMROOT=build.appas a proper IPA (mkdir build/ipa/Payload,cp -r Flean.app,zip ../Flean.ipa Payload) inprerelease.ymlprerelease.yml→Flean.ipa/application/octet-streambuild-and-release.ymlbuild-and-release.yml→Flean.ipa/application/octet-stream⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.