fix(session-tracker): prevent bypass memory leak in OpenCode provider by Ostico · Pull Request #502 · Signet-AI/signetai

Ostico · 2026-04-13T18:01:46Z

Summary

The OpenCode pipeline provider creates daemon-owned sessions that are bypassed to prevent circular hook loops. When sessions rotate (structured output rejection, 404/410, malformed payload), unbypassSession() removed the bypass on the old session — but OpenCode kept that session alive and continued sending hooks to it, re-triggering the full memory recall loop. Additionally, bypass-only entries (sessions with allowUnknown: true that never enter the sessions Map) were stored in a Set<string> with no expiry, so they accumulated monotonically across daemon uptime.

This PR removes all unbypassSession() calls from the provider, changes the bypass store from Set<string> to Map<string, number> (key → expiresAt), and lets the existing cleanupStaleSessions interval evict expired bypass entries.

Changes

packages/daemon/src/session-tracker.ts — bypassedSessions from Set<string> to Map<string, number> with TTL; bypassSession() accepts optional ttlMs; isSessionBypassed() checks expiry and auto-evicts; cleanupStaleSessions() sweeps expired bypass-only entries; new runStaleCleanup() test export; bypass/unbypass log level lowered to debug
packages/daemon/src/pipeline/provider.ts — removed all 4 unbypassSession() calls and unused import; fixed misleading "bounded by workers" comment to reference TTL cleanup
packages/daemon/src/session-tracker.test.ts — 6 new tests covering allowUnknown bypass, TTL expiry/cleanup, and session rotation persistence
packages/daemon/src/memory-config.ts — fixed stray character causing parser error (separate commit)

Type

fix — bug fix

Packages affected

@signet/daemon

Screenshots

N/A — no UI changes.

PR Readiness (MANDATORY)

Spec alignment validated (INDEX.md + dependencies.yaml) — no spec-governed behavior changed; internal session-tracker plumbing only
Agent scoping verified on all new/changed data queries — no data queries changed
Input/config validation and bounds checks added — ttlMs defaults to STALE_SESSION_MS (4h); expiry timestamps validated in isSessionBypassed
Error handling and fallback paths tested (no silent swallow) — bypass expiry is lazy-evict + periodic sweep, both tested
Security checks applied to admin/mutation endpoints — no endpoints changed
Docs updated for API/spec/status changes — no API/spec/status changes
Regression tests added for each bug fix — 6 new tests in session-tracker.test.ts
Lint/typecheck/tests pass locally

Testing

bun test passes (15/15 across session-tracker, session-api, hooks-recall)
bun run typecheck passes — pre-existing memory-config.ts parser error on main (the stray character fix in this PR resolves it)
bun run lint passes (Biome clean on all changed files)
Tested against running daemon — live-tested with source daemon, confirmed circular loop eliminated via debug logging across 3 daemon restarts

AI disclosure

No AI tools were used in this PR
AI tools were used (see Assisted-by tags in commits)

Notes

The memory-config.ts typo fix (stray p after comma on line 833) is a pre-existing issue on main that breaks bun run build. It's in a separate commit (chore(daemon): fix stray character in memory-config parser).
getBypassedSessionKeys() return type changed from ReadonlySet<string> to ReadonlyMap<string, number>. The only consumer (pipeline-routes.ts) uses .size which works on both — no breaking change.
The 23 pre-existing test failures in worker.test.ts are unrelated to this PR (they fail on main as well).

The OpenCode provider creates sessions for pipeline work (extraction, hints, summaries). The OpenCode plugin intercepts those prompts and calls hook endpoints back to the daemon, triggering full memory recall for the daemon's own internal prompts. This circular loop adds 30-90s overhead per pipeline call, causing systematic timeouts. Register each daemon-created OpenCode session in the bypass set via bypassSession(). When hooks arrive for that session, checkBypass() returns empty no-op responses instantly, breaking the loop. Clean up bypass state on all session invalidation paths (404, 422, malformed 200).

bypassedSessions changed from Set<string> to Map<string, number> so bypass-only entries (pipeline sessions with allowUnknown) expire and get evicted by cleanupStaleSessions. Removes all unbypassSession calls from the OpenCode provider — old sessions stay bypassed until TTL cleanup handles them, closing the circular hook loop root cause.

PR-Reviewer-Ant · 2026-04-13T18:02:10Z