Fix sample_reconstruction_plots option for non-SBS96 signatures#197
Open
takahiro-blab wants to merge 1 commit intoSigProfilerSuite:mainfrom
Open
Fix sample_reconstruction_plots option for non-SBS96 signatures#197takahiro-blab wants to merge 1 commit intoSigProfilerSuite:mainfrom
takahiro-blab wants to merge 1 commit intoSigProfilerSuite:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sample_reconstruction_plotsoption inspa_analyzemethod only functions with the SBS96 signature.However, by tracing the
generate_sample_reconstructionmethod andgen_decompositionmethod inPlotDecomposition.py, I noticed that processing for ID83 is implemented.Therefore, I modified the
spa_analyzemethod to remove the check that restricted it to SBS96 cases.Addition: In
PlotDecomposition.py'sgen_decompositionmethod, if the processing for the signature passed as an argument is not implemented, it simply prints a message. It might be preferable to replace this with raising exception.