Skip to content

Fix agent stuck in waiting state after completion#343

Open
satti-hari-krishna-reddy wants to merge 3 commits intoShuffle:mainfrom
satti-hari-krishna-reddy:timeout-fix
Open

Fix agent stuck in waiting state after completion#343
satti-hari-krishna-reddy wants to merge 3 commits intoShuffle:mainfrom
satti-hari-krishna-reddy:timeout-fix

Conversation

@satti-hari-krishna-reddy
Copy link
Collaborator

No description provided.

formattedAppName := strings.ReplaceAll(strings.ToLower(app.Name), " ", "_")

isInternalShuffleApp := false
switch formattedAppName {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about just matching name seems off, but I'm not sure exactly why.

I wonder if there is a way to "steal" the URL field/apikey by formatting an app in a certain way.

Just need to think it over before merging 🤔


returnAction, err := HandleAiAgentExecutionStart(workflowExecution, actionResult.Action, true)
var originalAction Action
if foundActionResultIndex >= 0 && foundActionResultIndex < len(workflowExecution.Results) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the point of this? I'm always confused when we override actions, when things used to work without it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants