Skip to content

fix: normalize environment casing in workflow actions and triggers #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0x0elliot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: normalize environment casing in workflow actions and triggers #337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da6c104
fix: normalize environment casing in workflow actions and triggers
0x0elliot Feb 25, 2026
5f07652
fix: condition normalization logging on debug flag
0x0elliot Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion db-connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3413,7 +3413,7 @@ func GetWorkflow(ctx context.Context, id string, skipHealth ...bool) (*Workflow,
return workflow, nil
}
} else {
if debug {
if debug {
log.Printf("[DEBUG] Failed getting cache for workflow: %s", err)
}
}
Expand Down Expand Up @@ -9121,6 +9121,23 @@ func SetWorkflow(ctx context.Context, workflow Workflow, id string, optionalEdit

workflow = FixWorkflowPosition(ctx, workflow)

for actionIndex, action := range workflow.Actions {
if strings.ToLower(action.Environment) == "cloud" && action.Environment != "cloud" {
if debug {
log.Printf("[DEBUG] Normalized action environment from '%s' to 'cloud' in workflow %s", action.Environment, workflow.ID)
}
workflow.Actions[actionIndex].Environment = "cloud"
}
}
for triggerIndex, trigger := range workflow.Triggers {
if strings.ToLower(trigger.Environment) == "cloud" && trigger.Environment != "cloud" {
if debug {
log.Printf("[DEBUG] Normalized trigger environment from '%s' to 'cloud' in workflow %s", trigger.Environment, workflow.ID)
}
workflow.Triggers[triggerIndex].Environment = "cloud"
}
}

// New struct, to not add body, author etc
data, err := json.Marshal(workflow)
if err != nil {
Expand Down
Loading