Skip to content

Make SharedAttachment in ShareMedia non-nullable, because ShareAttachment.decode takes a non-nullable parameter any ways #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saibotma wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make SharedAttachment in ShareMedia non-nullable, because ShareAttachment.decode takes a non-nullable parameter any ways #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions share_handler_platform_interface/lib/src/data/messages.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class SharedMedia {
});

/// List of shared attachments (ex. images, videos, pdfs, etc.). Each attachment has an attachment type and a path to the file on the device.
List<SharedAttachment?>? attachments;
List<SharedAttachment>? attachments;

/// iOS only: List of recipient identifiers from iOS intent.
List<String?>? recipientIdentifiers;
Expand Down Expand Up @@ -96,9 +96,9 @@ class SharedMedia {
static SharedMedia decode(Object message) {
final Map<Object?, Object?> pigeonMap = message as Map<Object?, Object?>;
return SharedMedia(
attachments: (pigeonMap['attachments'] as List<Object?>?)
?.map((e) => SharedAttachment.decode(e as Map<Object?, Object?>))
.cast<SharedAttachment?>()
attachments: (pigeonMap['attachments'] as List<dynamic>?)
?.cast<Map<Object?, Object?>>()
.map(SharedAttachment.decode)
.toList(),
recipientIdentifiers: (pigeonMap['recipientIdentifiers'] as List<Object?>?)?.cast<String?>(),
conversationIdentifier: pigeonMap['conversationIdentifier'] as String?,
Expand Down