Skip to content

fix(prettier-plugin-liquid): preserve U+00A0 and don't drop borrowed closing tags #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BJvdA wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(prettier-plugin-liquid): preserve U+00A0 and don't drop borrowed closing tags #1191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fbadc8
fix: non-breaking spaces bug
BJvdA Apr 22, 2026
d0b6954
chore: add changeset for nbsp html text fix
BJvdA Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/preserve-nbsp-html-text.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/prettier-plugin-liquid': patch
---

Preserve non-breaking spaces (U+00A0) in HTML text nodes and stop dropping borrowed closing tag markers when a text node is pure whitespace.
16 changes: 14 additions & 2 deletions packages/prettier-plugin-liquid/src/printer/printer-liquid-html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,15 +158,27 @@ function printTextNode(

if (isYamlFrontMatter(node)) return node.value;

if (node.value.match(/^\s*$/)) return '';
// Only ASCII/HTML whitespace is collapsible. Do not treat U+00A0 (NBSP) or
// other unicode "whitespace" as collapsible, since they are meaningful
// characters in the rendered output.
const HTML_WHITESPACE_RUN = /[ \t\n\r\f]+/g;
const HTML_WHITESPACE_TRIM = /^[ \t\n\r\f]+|[ \t\n\r\f]+$/g;

// If the text is purely collapsible whitespace we still need to emit the
// open/close prefixes so that any tag markers borrowed from the parent
// aren't lost (see needsToBorrowParentClosingTagStartMarker).
if (node.value.replace(HTML_WHITESPACE_RUN, '') === '') {
return [printOpeningTagPrefix(node, options), printClosingTagSuffix(node, options)];
}

const text = node.value;

const paragraphs = text
.split(/(\r?\n){2,}/)
.filter(Boolean) // removes empty paragraphs (trailingWhitespace)
.map((curr) => {
let doc = [];
const words = curr.trim().split(/\s+/g);
const words = curr.replace(HTML_WHITESPACE_TRIM, '').split(HTML_WHITESPACE_RUN);
let isFirst = true;
for (let j = 0; j < words.length; j++) {
const word = words[j];
Expand Down
5 changes: 5 additions & 0 deletions packages/prettier-plugin-liquid/src/test/unit-paragraphs/fixed.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,8 @@ printWidth: 20
>Lorem Ipsum</span
>
</p>

it should preserve non-breaking spaces (U+00A0) as text and not drop borrowed closing tags
<p>
<strong><em> </em></strong>
</p>
3 changes: 3 additions & 0 deletions packages/prettier-plugin-liquid/src/test/unit-paragraphs/index.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,6 @@ printWidth: 20
<p>
{{ drop }}<span>Lorem Ipsum</span>
</p>

it should preserve non-breaking spaces (U+00A0) as text and not drop borrowed closing tags
<p><strong><em> </em></strong></p>
Loading