Add font preconnect and preloading #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
karreiro
reviewed
Nov 7, 2025
Contributor
There was a problem hiding this comment.
Thank you for this PR, @retlehs!
I have discussed this with a few peers to understand the usage that balances performance and context well in most of the themes, and I have left only one minor suggestion with that context in mind.
Please let me know your thoughts, and thanks again for this PR!
Co-authored-by: Guilherme Carreiro <karreiro@gmail.com>
Contributor
Author
|
@karreiro Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds font preloading to improve initial page render performance
preconnectto the fonts CDNpreload_tagfor the primary font variant(Shopify still needs to fix the
crossoriginbug inpreload_tag— see #46)This is the new markup added with this PR on a deployed skeleton theme: