Skip to content

Discard jobs where the record cannot be found #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bbbriana wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Discard jobs where the record cannot be found #1457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/jobs/shipit/background_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ class << self

DEFAULT_RETRY_TIME_IN_SECONDS = 30

# If the record was deleted before the job ran, there's nothing to do
discard_on(ActiveRecord::RecordNotFound)

# Write actions can sometimes fail intermittently, particulary for large and/or busy repositories
retry_on(Octokit::ServerError)

Expand Down