Conversation
Morriar
force-pushed
the
at/bump-rubocop
branch
2 times, most recently
from
73f786e to
60827ee
Compare
Morriar
force-pushed
the
at/bump-rubocop
branch
from
60827ee to
12506a2
Compare
Morriar
force-pushed
the
at/bump-minitest
branch
from
a879bd9 to
b0c50cc
Compare
Morriar
force-pushed
the
at/bump-rubocop
branch
from
12506a2 to
451a02a
Compare
Morriar
force-pushed
the
at/bump-minitest
branch
from
b0c50cc to
c259f99
Compare
Morriar
force-pushed
the
at/bump-rubocop
branch
from
451a02a to
f7936dd
Compare
Morriar
force-pushed
the
at/bump-minitest
branch
from
c259f99 to
d0e8581
Compare
Morriar
force-pushed
the
at/bump-rubocop
branch
from
f7936dd to
f34e427
Compare
Morriar
force-pushed
the
at/bump-minitest
branch
from
d0e8581 to
aef98e7
Compare
Morriar
force-pushed
the
at/bump-rubocop
branch
from
f34e427 to
888f03d
Compare
Morriar
force-pushed
the
at/bump-minitest
branch
from
aef98e7 to
9a55b0c
Compare
Morriar
force-pushed
the
at/bump-rubocop
branch
from
888f03d to
1c96b0c
Compare
Morriar
force-pushed
the
at/bump-minitest
branch
from
9a55b0c to
5ca682c
Compare
Morriar
force-pushed
the
at/bump-rubocop
branch
from
1c96b0c to
90e1f2e
Compare
Morriar
force-pushed
the
at/bump-minitest
branch
from
5ca682c to
da9998c
Compare
Morriar
force-pushed
the
at/bump-rubocop
branch
from
90e1f2e to
5fa5a4e
Compare
Morriar
force-pushed
the
at/bump-rubocop
branch
3 times, most recently
from
8f13ede to
2ee8a84
Compare
Bump rubocop (1.64.1 -> 1.86.1), rubocop-ast (1.31.3 -> 1.49.1), prism (0.27.0 -> 1.9.0), rbi (0.1.12 -> 0.3.10), and tapioca (0.15.1 -> 0.18.0). Replace `require "parser/ast/node"` and `require "parser/source/map"` with `require "parser"` to fix AST constant load order with parser 3.3.11.1. Use `Prism::Translation::Parser::Builder` as the base class for `TolerateInvalidUtf8Builder` when available (prism >= 1.5), fixing deprecation warnings from newer Prism versions that pollute stderr captures in tests. RuboCop 1.76+ recognizes `#|` continuation lines in RBS inline annotations when `AllowRBSInlineAnnotation` is enabled. Cap `parallel` to `< 2`, `rbi` to `< 0.3.11`, and `sorbet-static-and-runtime` to `< 0.6` to preserve Ruby 3.2 compatibility and avoid unrelated Sorbet strictness changes.
Morriar
commented
May 1, 2026
| gem("m") | ||
| gem("rake") | ||
| gem("sorbet-static-and-runtime") | ||
| gem("sorbet-static-and-runtime", "< 0.6") # Sorbet 0.6+ has stricter type checking, bumped separately |
Morriar
commented
May 1, 2026
| gem("rubocop-sorbet", require: false) | ||
| gem("mocha", require: false) | ||
| gem("rubocop-shopify", require: false) | ||
| gem("rbi", "< 0.3.11", require: false) # rbi 0.3.11+ requires Ruby >= 3.3 |
hmcguire-shopify
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require "parser/ast/node"andrequire "parser/source/map"withrequire "parser"to fix AST constant load order with parser 3.3.11.1Prism::Translation::Parser::Builderas base class forTolerateInvalidUtf8Builderwhen available (prism >= 1.5), fixing deprecation warnings#|continuation lines in RBS inline annotations whenAllowRBSInlineAnnotationis enabledparallelto< 2,rbito< 0.3.11, andsorbet-static-and-runtimeto< 0.6to preserve Ruby 3.2 compatibility