Skip to content

Conversation

@richardmarbach
Copy link

What are you trying to accomplish?

Since no further development has taken place on #243, I hope it's ok that I've taken the liberty to implement the requested changes from #243 (comment)

What approach did you choose and why?

What should reviewers focus on?

This is the first time I've used minitest. Would love some feedback on if there's a better way to write the tests.

Type of Change

  • Bugfix
  • New feature
  • Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Additional Release Notes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • It is safe to rollback this change.

@richardmarbach richardmarbach requested a review from a team as a code owner October 12, 2023 19:15
@richardmarbach richardmarbach deleted the configurable-parsers branch October 12, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants