Skip to content

Conversation

@davidstosik
Copy link
Contributor

@davidstosik davidstosik commented Feb 9, 2023

What are you trying to accomplish?

Remove an empty file in the repository's root named empty_commit.
The file was added in #276, where I could not find an explanation for its presence.

What approach did you choose and why?

git rm

What should reviewers focus on?

My assumption is that this file was added in order to create an "empty commit" that would trigger CI.
I'd like to confirm that.

For reference, the following command creates an empty commit without the need to commit any file.

git commit --allow-empty --message="Empty commit"

Type of Change

  • Bugfix
  • New feature
  • Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Additional Release Notes

  • Breaking change (fix or feature that would cause existing functionality to change)

Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.

If no additional notes are necessary, delete this section or leave it unchanged.

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • It is safe to rollback this change.

@davidstosik davidstosik marked this pull request as ready for review February 9, 2023 23:56
@davidstosik davidstosik requested a review from a team as a code owner February 9, 2023 23:56
Copy link
Member

@gmcgibbon gmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Contributor

@alexevanczuk alexevanczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was definitely added accidentally, thanks for removing!

@alexevanczuk alexevanczuk merged commit fc1dc31 into main Feb 10, 2023
@alexevanczuk alexevanczuk deleted the sto/remove-empty_commit branch February 10, 2023 13:35
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems March 1, 2023 19:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants