Skip to content

Conversation

@peterzhu2118
Copy link
Contributor

Implement benchmarks for deserialize, and deserialize and render for Shopify/liquid-c#138.

Benchmark results:

              parse:    132.501  (± 3.0%) i/s -      1.326k in  10.019619s
             render:    236.153  (± 3.8%) i/s -      2.369k in  10.047556s
     parse & render:     75.737  (± 4.0%) i/s -    756.000  in  10.001978s
        deserialize:    163.091  (± 2.5%) i/s -      1.632k in  10.014565s
deserialize & render:
                         87.536  (± 2.3%) i/s -    880.000  in  10.060593s

Copy link
Contributor

@macournoyer macournoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Very nice 👏

@dylanahsmith
Copy link
Contributor

It seems like it would be a lot cleaner to do this in the liquid-c repo using a separate call to Benchmark.ips for "deserialize" and ":deserialize & render". We could load the theme_runner and extend it before running the benchmark.

@peterzhu2118
Copy link
Contributor Author

Closing in favour of Shopify/liquid-c#141.

@peterzhu2118 peterzhu2118 deleted the pz-serialize-benchmark branch January 11, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants