Skip to content

Remove ignore_override flag #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adrianna-chang-shopify wants to merge 1 commit into from
Closed

Remove ignore_override flag #603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/identity_cache/query_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,11 @@ def cache_fetch_includes
# callback enqueues a background job, then we don't want it to be possible for the
# background job to run and load data from the cache before it is invalidated.
if ActiveRecord.version >= Gem::Version.new("7.1")
def run_callbacks(kind, type = nil, ignore_override: false)
if kind == :commit && (destroyed? || transaction_changed_attributes.present?) && !ignore_override
def run_callbacks(kind, type = nil)
if kind == :commit && (destroyed? || transaction_changed_attributes.present?)
expire_cache
end
super(kind, type)
super
end
else
def run_callbacks(kind)
Expand Down
Loading