Skip to content

Patch run_callbacks instead of _run_commit_callbacks #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrianna-chang-shopify wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −4
Open

Patch run_callbacks instead of _run_commit_callbacks #602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d4771c
Patch run_callbacks instead of _run_commit_callbacks
adrianna-chang-shopify Oct 22, 2025
eebc8d8
Add ignore_override parameter to run_callbacks
adrianna-chang-shopify Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions lib/identity_cache/query_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,20 @@ def cache_fetch_includes
# cache reads that happen from the ordering of callbacks. For example, if an after_commit
# callback enqueues a background job, then we don't want it to be possible for the
# background job to run and load data from the cache before it is invalidated.
def _run_commit_callbacks
if destroyed? || transaction_changed_attributes.present?
expire_cache
if ActiveRecord.version >= Gem::Version.new("7.1")
def run_callbacks(kind, type = nil, ignore_override: false)
Copy link
Member

@Edouard-chin Edouard-chin Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the ignore_override come from ?

I should RTFM

if kind == :commit && (destroyed? || transaction_changed_attributes.present?) && !ignore_override
expire_cache
end
super(kind, type)
end
else
def run_callbacks(kind)
if kind == :commit && (destroyed? || transaction_changed_attributes.present?)
expire_cache
end
super
end
super
end

# Invalidate the cache data associated with the record. Returns `true` on success,
Expand Down
Loading