chore(deps): bump vulnerable deps #3461
Conversation
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
| @@ -1,5 +1,5 @@ | |||
| import {CommandModule} from 'yargs'; | |||
| import {zodToJsonSchema} from 'zod-to-json-schema'; | |||
There was a problem hiding this comment.
as of zod 4 we no longer need to use an external library
| const error = { | ||
| validator: 'RecipeSchema', | ||
| message: 'Expected string, received number', | ||
| message: 'Invalid input: expected string, received number', |
There was a problem hiding this comment.
error message changed in zod 4
| const errors: ValidationError[] = error.issues.map((issue) => { | ||
| const lineNumber = getYamlLineNumber(recipeYamlPath, issue.path); | ||
| const actualValue = getYamlValue(recipeYamlPath, issue.path); | ||
| const issuePath = issue.path as (string | number)[]; |
There was a problem hiding this comment.
zod 4 fixed this type to PropertyKey (it was always PropertyKey in runtime, but it was typed as string | number)
| "inquirer": "^12.4.2", | ||
| "istextorbinary": "9.5.0", | ||
| "ts-node": "^10.9.2", | ||
| "yaml": "^2.4.2", |
There was a problem hiding this comment.
missing peer dep, npm hoisted from ✨somewhere✨
There was a problem hiding this comment.
all changes to this package were because there was a different version of prettier running on it and now it is all the same
i think
This comment has been minimized.
This comment has been minimized.
| '@shopify/cli-hydrogen': patch | ||
| --- | ||
|
|
||
| Updated `prettier` from v2 to v3. |
There was a problem hiding this comment.
is this harmless? i had to update a test snapshot because it formats thigns slightlyyy differently
i know cli-hydrogen formats files after it adds them to the projects – i wonder if it wouldn’t be best to have this as a peer dep instead in the future and avoid bundling it with the cli binary
the reason why is that the user may be using another version of prettier, or no prettier at all, in which case we simply should skip formatting instead of forcing down our version of it!
1 participant
low hanging fruit on dep versions
phase 1 (and a bit of 2) of https://github.com/orgs/Shopify/projects/4613/views/113?pane=issue&itemId=155935803&issue=Shopify%7Cdeveloper-tools-team%7C1035
Before
After