Skip to content

Remove dev session support branching#8019

Open
isaacroldan wants to merge 2 commits into
remove-draftable-extension-processfrom
remove-supports-dev-sessions
Open

Remove dev session support branching#8019
isaacroldan wants to merge 2 commits into
remove-draftable-extension-processfrom
remove-supports-dev-sessions

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Remove the supportsDevSessions client capability and make dev-session behavior unconditional.
  • Delete the legacy Partner Dashboard preview/scopes branches from app dev.
  • Default generated app configs to automatically update URLs on dev.
  • Remove unused developer preview helpers left behind by the cleanup.

Validation:

  • pnpm knip
  • pnpm vitest run packages/app/src/cli/services/dev.test.ts packages/app/src/cli/services/dev-clean.test.ts packages/app/src/cli/services/dev/ui.test.tsx packages/app/src/cli/services/dev/urls.test.ts packages/app/src/cli/services/dev/processes/setup-dev-processes.test.ts packages/app/src/cli/services/app/config/link.test.ts packages/app/src/cli/services/app/config/link-service.test.ts
  • pnpm --filter app type-check
  • pnpm --filter app lint

isaacroldan commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan marked this pull request as ready for review July 7, 2026 10:19
@isaacroldan isaacroldan requested review from a team as code owners July 7, 2026 10:19
@github-actions github-actions Bot added the Area: @shopify/app @shopify/app package issues label Jul 7, 2026
@isaacroldan isaacroldan changed the base branch from remove-draftable-extension-process to graphite-base/8019 July 7, 2026 13:11
@isaacroldan isaacroldan force-pushed the remove-supports-dev-sessions branch from d415c0a to 212da2f Compare July 7, 2026 13:12
@isaacroldan isaacroldan changed the base branch from graphite-base/8019 to remove-draftable-extension-process July 7, 2026 13:12
Assisted-By: devx/782ef931-ac0a-4cc4-bff1-a2511c379664
Assisted-By: devx/782ef931-ac0a-4cc4-bff1-a2511c379664
@isaacroldan isaacroldan force-pushed the remove-supports-dev-sessions branch from 212da2f to 87d82ff Compare July 7, 2026 13:31
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -6,7 +6,6 @@ export declare const environmentVariables: {
     doctor: string;
     enableCliRedirect: string;
     env: string;
-    firstPartyDev: string;
     noAnalytics: string;
     optOutInstrumentation: string;
     appAutomationToken: string;
packages/cli-kit/dist/public/node/context/local.d.ts
@@ -63,13 +63,6 @@ export declare function alwaysLogAnalytics(env?: NodeJS.ProcessEnv): boolean;
  * @returns True if SHOPIFY_CLI_ALWAYS_LOG_METRICS is truthy.
  */
 export declare function alwaysLogMetrics(env?: NodeJS.ProcessEnv): boolean;
-/**
- * Returns true if the CLI User is 1P.
- *
- * @param env - The environment variables from the environment of the current process.
- * @returns True if SHOPIFY_CLI_1P is truthy.
- */
-export declare function firstPartyDev(env?: NodeJS.ProcessEnv): boolean;
 /**
  * Returns true if the CLI can run the "doctor-release" command.
  *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/app @shopify/app package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant