[Performance] Memoize isStdinPiped in cli-kit#7999
Conversation
Memoize the `isStdinPiped` function in `packages/cli-kit/src/public/node/system.ts` to avoid redundant synchronous `fstatSync(0)` calls. The piping status of stdin is constant for the duration of the process. Added an exported `_resetIsStdinPipedCache` utility for test isolation and updated `system.test.ts` to verify memoization. Expected impact: Reduces CPU time by skipping redundant syscalls in high-frequency paths or utility functions that depend on stdin status.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/system.d.ts@@ -111,6 +111,11 @@ export declare function isCI(): boolean;
* @returns True if the current environment is a WSL environment.
*/
export declare function isWsl(): Promise<boolean>;
+/**
+ * Reset the memoized value for the stdin piped check.
+ * This is only used for testing.
+ */
+export declare function _resetIsStdinPipedCache(): void;
/**
* Check if stdin has piped data available.
* This distinguishes between actual piped input (e.g., )
|
Why is this change needed?
The
isStdinPipedfunction performs a synchronousfstatSync(0)call to determine if stdin is piped. In a CLI environment, this status remains constant throughout the process execution. Repeated calls to this function (either directly or via other utilities likereadStdinString) result in redundant system calls.How to test your changes?
CI
Post-deployment steps
None.
PR created automatically by Jules for task 16902672566824217517 started by @gonzaloriestra