Skip to content

[Performance] Memoize isStdinPiped in cli-kit#7999

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-is-stdin-piped-16902672566824217517
Draft

[Performance] Memoize isStdinPiped in cli-kit#7999
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-is-stdin-piped-16902672566824217517

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

Why is this change needed?

The isStdinPiped function performs a synchronous fstatSync(0) call to determine if stdin is piped. In a CLI environment, this status remains constant throughout the process execution. Repeated calls to this function (either directly or via other utilities like readStdinString) result in redundant system calls.

How to test your changes?

CI

Post-deployment steps

None.


PR created automatically by Jules for task 16902672566824217517 started by @gonzaloriestra

Memoize the `isStdinPiped` function in `packages/cli-kit/src/public/node/system.ts` to avoid redundant synchronous `fstatSync(0)` calls. The piping status of stdin is constant for the duration of the process.

Added an exported `_resetIsStdinPipedCache` utility for test isolation and updated `system.test.ts` to verify memoization.

Expected impact: Reduces CPU time by skipping redundant syscalls in high-frequency paths or utility functions that depend on stdin status.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 5, 2026
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/system.d.ts
@@ -111,6 +111,11 @@ export declare function isCI(): boolean;
  * @returns True if the current environment is a WSL environment.
  */
 export declare function isWsl(): Promise<boolean>;
+/**
+ * Reset the memoized value for the stdin piped check.
+ * This is only used for testing.
+ */
+export declare function _resetIsStdinPipedCache(): void;
 /**
  * Check if stdin has piped data available.
  * This distinguishes between actual piped input (e.g., )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant