[Refactor] modernize errorHandler and improve test coverage#7997
[Refactor] modernize errorHandler and improve test coverage#7997gonzaloriestra wants to merge 1 commit into
Conversation
Refactor errorHandler in @shopify/cli-kit to use async/await and early returns for better readability. Added a unit test for AbortSilentError to ensure it is handled silently.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
errorHandlerfunction in@shopify/cli-kitused an older Promise-based pattern with.then()chains, which was less readable and more difficult to maintain than modernasync/await. Additionally, theAbortSilentErrorbranch was not explicitly verified by unit tests.WHAT is this pull request doing?
errorHandlerinpackages/cli-kit/src/public/node/error-handler.tsto useasync/awaitsyntax.CancelExecutionandAbortSilentError, reducing nesting.packages/cli-kit/src/public/node/error-handler.test.tsto verify thatAbortSilentErroris handled silently without exiting or logging.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 11091565751469337296 started by @gonzaloriestra