[Tests] Replace filesystem mocks in store execute result tests#7996
[Tests] Replace filesystem mocks in store execute result tests#7996gonzaloriestra wants to merge 1 commit into
Conversation
Refactor `packages/store/src/cli/services/store/execute/result.test.ts` to remove module-level filesystem mocks and use `inTemporaryDirectory` and `readFile` for actual filesystem operations. This adheres to the testing protocol of testing behavior over implementation details and avoiding filesystem mocks.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
This PR refactors the unit tests for
writeOrOutputStoreExecuteResultto replace filesystem mocks with real filesystem operations using temporary directories. This aligns with the repository's testing best practices of testing real behavior and avoiding mocks of core utilities like@shopify/cli-kit/node/fs.WHAT is this pull request doing?
vi.mock('@shopify/cli-kit/node/fs')frompackages/store/src/cli/services/store/execute/result.test.ts.inTemporaryDirectoryandjoinPath.writeFilecalls with actual file content verification usingreadFile.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 10145309229126400021 started by @gonzaloriestra