Skip to content

[Tests] Replace filesystem mocks in store execute result tests#7996

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-refactor-fs-mock-store-result-10145309229126400021
Draft

[Tests] Replace filesystem mocks in store execute result tests#7996
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-refactor-fs-mock-store-result-10145309229126400021

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

This PR refactors the unit tests for writeOrOutputStoreExecuteResult to replace filesystem mocks with real filesystem operations using temporary directories. This aligns with the repository's testing best practices of testing real behavior and avoiding mocks of core utilities like @shopify/cli-kit/node/fs.

WHAT is this pull request doing?

  • Removed vi.mock('@shopify/cli-kit/node/fs') from packages/store/src/cli/services/store/execute/result.test.ts.
  • Updated tests that write to files to use inTemporaryDirectory and joinPath.
  • Replaced assertions on writeFile calls with actual file content verification using readFile.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 10145309229126400021 started by @gonzaloriestra

Refactor `packages/store/src/cli/services/store/execute/result.test.ts` to
remove module-level filesystem mocks and use `inTemporaryDirectory` and
`readFile` for actual filesystem operations. This adheres to the testing
protocol of testing behavior over implementation details and avoiding
filesystem mocks.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant