Skip to content

[Tests] Replace filesystem mocks in asset-ignore.test.ts#7988

Open
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-replace-fs-mocks-asset-ignore-4844028106710873482
Open

[Tests] Replace filesystem mocks in asset-ignore.test.ts#7988
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-replace-fs-mocks-asset-ignore-4844028106710873482

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Follow the automated testing protocol to replace filesystem mocks with real operations, improving test reliability and reducing maintenance burden.

WHAT is this pull request doing?

Refactored packages/theme/src/cli/utilities/asset-ignore.test.ts to:

  • Use inTemporaryDirectory and writeFile instead of mocking @shopify/cli-kit/node/fs.
  • Remove manual mocks for readFile and fileExists.
  • Fix a duplicate test case description.

How to test your changes?

CI

Post-release steps

None

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 4844028106710873482 started by @gonzaloriestra

@gonzaloriestra
[Tests] Replace filesystem mocks in asset-ignore.test.ts
cd9904c 
Refactor `packages/theme/src/cli/utilities/asset-ignore.test.ts` to replace
manual mocks of `@shopify/cli-kit/node/fs` with real operations using
`inTemporaryDirectory` and `writeFile`. This adheres to the automated
testing protocol and improves test reliability.

- Replace `vi.mock('@shopify/cli-kit/node/fs', ...)` with real imports.
- Use `inTemporaryDirectory` for `getPatternsFromShopifyIgnore` tests.
- Create real `.shopifyignore` files using `writeFile`.
- Fix a duplicate test case description.
@google-labs-jules

google-labs-jules Bot commented Jul 3, 2026

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 3, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label Jul 3, 2026
@gonzaloriestra gonzaloriestra marked this pull request as ready for review July 3, 2026 09:54
@gonzaloriestra gonzaloriestra requested review from a team as code owners July 3, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gonzaloriestra