Skip to content

[Performance] Memoize isTerminalInteractive#7972

Closed
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-is-terminal-interactive-151826568706229761
Closed

[Performance] Memoize isTerminalInteractive#7972
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-is-terminal-interactive-151826568706229761

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

Memoize the isTerminalInteractive function in @shopify/cli-kit to avoid redundant environment variable and stream property lookups. Added a reset utility for test isolation.


PR created automatically by Jules for task 151826568706229761 started by @gonzaloriestra

Memoize the `isTerminalInteractive` function in `@shopify/cli-kit` to avoid redundant environment variable and stream property lookups. This optimization improves efficiency in hot paths where terminal interactivity is checked frequently.

A `_resetIsTerminalInteractiveCache` utility was added and integrated into unit tests to ensure proper test isolation.

Expected impact: Measurable reduction in redundant lookups for `process.stdout.isTTY`, `process.env.TERM`, and `process.env.CI`.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/context/local.d.ts
@@ -5,6 +5,10 @@ import { Metadata } from '../../../private/node/context/utilities.js';
  * @returns True if the terminal is interactive.
  */
 export declare function isTerminalInteractive(): boolean;
+/**
+ * Resets the memoized value for the terminal interactive check.
+ */
+export declare function _resetIsTerminalInteractiveCache(): void;
 /**
  * Returns the path to the user's home directory.
  *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant