Remove jose from cli-kit (inline guarded JWT decode)#7730
Draft
amcaplan wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
josefrom@shopify/cli-kitWhy: Part of an initiative to cut low-value dependency churn (13 Dependabot bumps / 24 months). Notably, this code path only ever decoded an
id_tokenpayload — it never verified signatures, so the fulljoselibrary was overkill.Replacement: A guarded inline base64url JWT-payload decoder.
packages/cli-kit/src/private/node/session/exchange.ts—jose.decodeJwt(result.id_token).sub→getJwtSubject(idToken).Buffer.from(payload, 'base64url')(engines.node ≥ 22.12);JSON.parsewrapped in try/catch; rejects non-object / array / empty-object payloads before reading.sub(avoids theString.prototype.subhazard a string payload would trigger).string | undefined; the existing caller'sif (!userId) throw new BugError(...)already handles a missing subject — safer than the prior.sub!non-null assertion.Tests: The decode path was previously untested. Added coverage in
exchange.test.tsforexchangeDeviceCodeForAccessTokenwithout anexistingUserId(the path that triggers the decode) plus malformed-token guard cases.Validation:
type-check✅,lint✅,vitest✅ (1 file, 19 tests, 0 failed).🤖 AI-generated draft — needs human review before merge.