Remove semver from cli-kit/app#7726
Draft
amcaplan wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
semverfrom@shopify/cli-kitWhy:
semveris a high-churn dependency (56 Dependabot bumps / 24 months). Part of an initiative to cut low-value dependency churn in the CLI monorepo.Replacement: Swapped to
compare-versions(already in the tree) plus small inline helpers.versionSatisfiescontract is preserved exactly (same return semantics for caret/tilde/range inputs)..majorextraction reimplemented via a small local helper.packages/cli-kit/src/public/node/version.ts,packages/cli-kit/src/public/node/node-package-manager.ts.Validation:
type-check✅,lint✅,vitest✅ (version: 65 tests, node-package-manager: 95 tests — all green). Parity tests added forversionSatisfiesedge cases and.major.Scope note: An earlier draft of this branch included an unrelated edit; it has been reverted. Diff is now limited to the 6 relevant files + lockfile reflow + changeset.
🤖 AI-generated draft — needs human review before merge.