Remove ansi-escapes from cli-kit (inline OSC-8 hyperlink)#7722
Draft
amcaplan wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
ansi-escapesnpm dependency from@shopify/cli-kitand replaces its only usage with a self-contained 3-line OSC-8 hyperlink helper.Why
ansi-escapeshas generated 52 Dependabot version bumps over 24 months in this repo. The only API used isansiEscapes.link(text, url), which is a trivial OSC-8 escape sequence. Inlining it eliminates the dependency entirely, reducing Dependabot churn with no functional change.Implementation
The replacement helper (BEL terminator variant, matches the original library's output):
Applied to:
packages/cli-kit/src/private/node/ui/components/Link.tsxpackages/cli-kit/src/private/node/content-tokens.tsPlatform/terminal hyperlink support detection continues to be handled externally by
supports-hyperlinks— no change to that logic.Validation
pnpm --filter @shopify/cli-kit type-check— passespnpm --filter @shopify/cli-kit lint— passespnpm --filter @shopify/cli-kit exec vitest run— Link + content-tokens tests: 10/10 passing🤖 Automated dependency-removal initiative — AI-generated draft, needs human review.