[Tests] Remove filesystem mocks in app-logs-polling.test.ts#7720
[Tests] Remove filesystem mocks in app-logs-polling.test.ts#7720gonzaloriestra wants to merge 1 commit into
Conversation
This PR refactors `packages/app/src/cli/services/dev/processes/app-logs-polling.test.ts` to replace `vi.mock('@shopify/cli-kit/node/fs')` with real filesystem operations using the `inTemporaryDirectory` utility.
Key changes:
- Removed global filesystem mock.
- Wrapped each test case in `inTemporaryDirectory`.
- Updated `testAppWithConfig` and `testFunctionExtension` to use paths within the temporary directory.
- Replaced `mkdir` mock assertions with `fileExists` checks on the real filesystem.
- Improved test isolation by moving setup from `beforeEach` to individual test blocks.
- Fixed linting and type-check issues introduced during the refactor.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
Why is this change necessary?
Following the testing protocol to avoid mocking the filesystem and instead use real temporary directories for more reliable tests.
How to test your changes?
CI
PR created automatically by Jules for task 4662098806550787437 started by @gonzaloriestra