[Security] Harden downloadFile with response validation#7713
[Security] Harden downloadFile with response validation#7713gonzaloriestra wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
…cleanup Harden downloadFile in packages/cli-kit/src/public/node/http.ts by adding checks for res.ok and res.body. If these checks fail, the promise is rejected with a descriptive error message. Improved the cleanup logic to ensure the file stream is destroyed before unlinking, which releases file handles and improves stability. Added a regression test in packages/cli-kit/src/public/node/http.test.ts to verify that 500 errors trigger correct failure and cleanup.
1 participant
WHY are these changes introduced?
Context about the problem that's being addressed:
The
downloadFilefunction did not validate the HTTP response status, potentially leading to cases where an error page (e.g., 404 or 500) was saved to disk as if it were the intended file.WHAT is this pull request doing?
Summary of the changes committed:
Hardened
downloadFileinpackages/cli-kit/src/public/node/http.tsby adding checks forres.okandres.body. If these checks fail, the partially downloaded file is removed and the promise is rejected with a descriptive error message. Added a regression test inpackages/cli-kit/src/public/node/http.test.ts.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 1835591128841729605 started by @gonzaloriestra