Fix theme dev storefront host for preview stores#7667
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2a56df6 to
a752730
Compare
a752730 to
3424286
Compare
5be05a2 to
dbab9b4
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/local-storage.d.ts@@ -34,6 +34,19 @@ export declare class LocalStorage<T extends Record<string, any>> {
* @throws BugError if an unexpected error occurs.
*/
delete<TKey extends keyof T>(key: TKey): void;
+ /**
+ * Get every pair currently held in the local storage.
+ *
+ * Useful for callers that need to enumerate all stored values without knowing the
+ * full set of keys in advance (for example, a command iterating over every
+ * stored session). The package stores its entire state as a single JSON
+ * object, so this is just a typed wrapper around that object.
+ *
+ * @returns An array of tuples.
+ * @throws AbortError if a permission error occurs.
+ * @throws BugError if an unexpected error occurs.
+ */
+ entries(): [keyof T, T[keyof T]][];
/**
* Clear the local storage (delete all values).
*
|
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |

WHY are these changes introduced?
Preview-store and local development can require separate URLs for Admin API, storefront rendering, theme editor, and shareable storefront preview access.
theme devpreviously had one store host and used it for all generated links and local rendering. That breaks prototype preview-store flows where the Admin API host is usable but browser-facing links need different routing or a backend-generated tokenized preview URL.WHAT is this pull request doing?
storefrontFqdnto theme dev server sessions.storeFqdn, while SFR rendering/proxy/cookie-domain handling can usestorefrontFqdnwhen explicitly provided.theme dev --storefront-host/SHOPIFY_FLAG_STOREFRONT_HOSTfor experiments where storefront rendering differs from--store.theme dev --preview-url/SHOPIFY_FLAG_PREVIEW_URLso preview-store flows can show/open a backend-generated preview URL instead of the standard?preview_theme_id=URL.admin.shop.dev/store/<shop>/themes/<theme>/editor) while preserving the original/admin/themes/...URL for normal stores.How to test your changes?
Automated checks run locally:
Manual smoke test target:
If a preview-store environment needs explicit storefront/preview routing, pass:
Checklist