Skip to content

Allow app config validate to target config by client ID#7631

Open
gonzaloriestra wants to merge 1 commit into
cli-interactivity/app-config-linkfrom
cli-interactivity/app-config-validate
Open

Allow app config validate to target config by client ID#7631
gonzaloriestra wants to merge 1 commit into
cli-interactivity/app-config-linkfrom
cli-interactivity/app-config-validate

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented May 25, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The interactivity audit found that shopify app config validate --client-id <id> can still prompt while resolving the active local config, especially when the cached config points at a file that no longer exists.

WHAT is this pull request doing?

  • Skips active-config recovery prompts during the validation preflight when --client-id is provided.
  • Preserves the existing interactive config recovery behavior when --client-id is not provided.

How to test your changes?

Remove the current config and pass a client from another one. It should validate without asking for the config.

shopify app config validate --client-id

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

gonzaloriestra commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 25, 2026
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-validate branch from 51b7815 to 63fab66 Compare June 1, 2026 11:43
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-link branch 2 times, most recently from 22f6bf8 to 1dcfefd Compare June 1, 2026 11:58
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-validate branch 2 times, most recently from 4bd2cf5 to 986b2a7 Compare June 1, 2026 12:20
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -7,6 +7,7 @@ export declare const environmentVariables: {
     enableCliRedirect: string;
     env: string;
     firstPartyDev: string;
+    hostedApps: string;
     noAnalytics: string;
     optOutInstrumentation: string;
     appAutomationToken: string;
packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "4.1.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "4.0.0";
\ No newline at end of file
packages/cli-kit/dist/public/node/context/local.d.ts
@@ -42,6 +42,13 @@ export declare function isShopify(env?: NodeJS.ProcessEnv): Promise<boolean>;
  * @returns True if the SHOPIFY_UNIT_TEST environment variable is truthy.
  */
 export declare function isUnitTest(env?: NodeJS.ProcessEnv): boolean;
+/**
+ * Returns true if the CLI is running in hosted apps mode.
+ *
+ * @param env - The environment variables from the environment of the current process.
+ * @returns True if the HOSTED_APPS environment variable is truthy.
+ */
+export declare function isHostedAppsMode(env?: NodeJS.ProcessEnv): boolean;
 /**
  * Returns true if reporting analytics is enabled.
  *

@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-validate branch from 986b2a7 to 872015f Compare June 1, 2026 12:45
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-link branch from 1dcfefd to 7bc268b Compare June 1, 2026 12:45
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-validate branch from 872015f to 81fed1d Compare June 15, 2026 10:53
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-link branch from 7bc268b to 2247c50 Compare June 15, 2026 10:53
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-validate branch from 81fed1d to 950e211 Compare June 16, 2026 08:58
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-link branch from 2247c50 to 87644b5 Compare June 16, 2026 08:58
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-validate branch 3 times, most recently from 8cfe2a7 to e2500b0 Compare June 16, 2026 13:14
@gonzaloriestra gonzaloriestra marked this pull request as ready for review June 16, 2026 13:22
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner June 16, 2026 13:22
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-link branch from 87644b5 to 772ca83 Compare July 1, 2026 14:10
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-validate branch from e2500b0 to 3913769 Compare July 1, 2026 14:10
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-link branch from 772ca83 to 4fc790f Compare July 2, 2026 11:33
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-validate branch 2 times, most recently from 2f2fa6d to d3c61c4 Compare July 2, 2026 12:07
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-link branch from 4fc790f to 7032f1f Compare July 2, 2026 12:07
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-link branch from 7032f1f to fed0194 Compare July 2, 2026 12:43
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner July 2, 2026 12:43
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-validate branch from d3c61c4 to 2dd690e Compare July 2, 2026 12:43
@github-actions github-actions Bot added Area: @shopify/app @shopify/app package issues and removed no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. labels Jul 2, 2026
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-validate branch from 2dd690e to 847afd2 Compare July 2, 2026 13:41
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/app-config-link branch from fed0194 to 7cb3d48 Compare July 2, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/app @shopify/app package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant