Skip to content

[Tests] Remove filesystem mocks in bundle-ui-step.test.ts#7571

Merged
gonzaloriestra merged 1 commit into
mainfrom
jules-tests-remove-fs-mocks-bundle-ui-step-18014390488825622297
May 21, 2026
Merged

[Tests] Remove filesystem mocks in bundle-ui-step.test.ts#7571
gonzaloriestra merged 1 commit into
mainfrom
jules-tests-remove-fs-mocks-bundle-ui-step-18014390488825622297

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented May 18, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Filesystem mocks in tests prevent verifying actual filesystem side effects and can lead to implementation-coupled tests that don't catch real-world path handling issues.

WHAT is this pull request doing?

Refactors `packages/app/src/cli/services/build/steps/bundle-ui-step.test.ts` to replace global `vi.mock('@shopify/cli-kit/node/fs')` with real filesystem operations using `inTemporaryDirectory`. It uses `mkdir` and `writeFile` to set up the test environment and `fileExists` to verify the success of `copyFile`.

How to test your changes?

CI

Post-release steps

N/A

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (`patch` for bug fixes · `minor` for new features · `major` for breaking changes) and added a changeset with `pnpm changeset add`

PR created automatically by Jules for task 18014390488825622297 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 18, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 18, 2026
@gonzaloriestra gonzaloriestra marked this pull request as ready for review May 18, 2026 11:51
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 18, 2026 11:51

@craigmichaelmartin craigmichaelmartin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See test comments

Comment thread .jules/tester.md Outdated
Comment thread packages/app/src/cli/services/build/steps/bundle-ui-step.test.ts
Comment thread packages/app/src/cli/services/build/steps/bundle-ui-step.test.ts
Comment thread packages/app/src/cli/services/build/steps/bundle-ui-step.test.ts
@gonzaloriestra gonzaloriestra force-pushed the jules-tests-remove-fs-mocks-bundle-ui-step-18014390488825622297 branch 2 times, most recently from cfb5cda to be962a5 Compare May 20, 2026 13:17
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 20, 2026 13:23
@gonzaloriestra gonzaloriestra force-pushed the jules-tests-remove-fs-mocks-bundle-ui-step-18014390488825622297 branch 2 times, most recently from 0a6eed0 to 9341f43 Compare May 20, 2026 13:50
@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/ui/components/AutocompletePrompt.d.ts
@@ -20,13 +20,6 @@ export interface AutocompletePromptProps<T> {
     abortSignal?: AbortSignal;
     infoMessage?: InfoMessageProps['message'];
     groupOrder?: string[];
-    /**
-     * Throttle window in milliseconds applied to the search callback. Defaults to 400ms,
-     * which is appropriate for remote/paginated backends. In-memory consumers (where the
-     * search callback resolves synchronously) can pass 0 for instant filtering on every
-     * keystroke.
-     */
-    searchDebounceMs?: number;
 }
-declare function AutocompletePrompt<T>({ message, choices, infoTable, onSubmit, search, hasMorePages: initialHasMorePages, abortSignal, infoMessage, groupOrder, searchDebounceMs, }: React.PropsWithChildren<AutocompletePromptProps<T>>): ReactElement | null;
+declare function AutocompletePrompt<T>({ message, choices, infoTable, onSubmit, search, hasMorePages: initialHasMorePages, abortSignal, infoMessage, groupOrder, }: React.PropsWithChildren<AutocompletePromptProps<T>>): ReactElement | null;
 export { AutocompletePrompt };
\ No newline at end of file

@gonzaloriestra gonzaloriestra force-pushed the jules-tests-remove-fs-mocks-bundle-ui-step-18014390488825622297 branch from 9341f43 to 0b9cedf Compare May 20, 2026 13:57
Refactor executeBundleUIStep tests to use real temporary directories
instead of global filesystem mocks. This ensures tests verify actual
file operations and handle path resolution nuances correctly.

Also fixes a CI failure by adding missing AttestationID scalar to
business-platform-organizations GraphQL types.
@gonzaloriestra gonzaloriestra force-pushed the jules-tests-remove-fs-mocks-bundle-ui-step-18014390488825622297 branch from 0b9cedf to 272ec98 Compare May 20, 2026 13:59
@gonzaloriestra gonzaloriestra added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 1054de5 May 21, 2026
26 of 28 checks passed
@gonzaloriestra gonzaloriestra deleted the jules-tests-remove-fs-mocks-bundle-ui-step-18014390488825622297 branch May 21, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants