[Tests] Remove filesystem mocks in bundle-ui-step.test.ts#7571
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
craigmichaelmartin
left a comment
There was a problem hiding this comment.
See test comments
cfb5cda to
be962a5
Compare
0a6eed0 to
9341f43
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/ui/components/AutocompletePrompt.d.ts@@ -20,13 +20,6 @@ export interface AutocompletePromptProps<T> {
abortSignal?: AbortSignal;
infoMessage?: InfoMessageProps['message'];
groupOrder?: string[];
- /**
- * Throttle window in milliseconds applied to the search callback. Defaults to 400ms,
- * which is appropriate for remote/paginated backends. In-memory consumers (where the
- * search callback resolves synchronously) can pass 0 for instant filtering on every
- * keystroke.
- */
- searchDebounceMs?: number;
}
-declare function AutocompletePrompt<T>({ message, choices, infoTable, onSubmit, search, hasMorePages: initialHasMorePages, abortSignal, infoMessage, groupOrder, searchDebounceMs, }: React.PropsWithChildren<AutocompletePromptProps<T>>): ReactElement | null;
+declare function AutocompletePrompt<T>({ message, choices, infoTable, onSubmit, search, hasMorePages: initialHasMorePages, abortSignal, infoMessage, groupOrder, }: React.PropsWithChildren<AutocompletePromptProps<T>>): ReactElement | null;
export { AutocompletePrompt };
\ No newline at end of file
|
9341f43 to
0b9cedf
Compare
Refactor executeBundleUIStep tests to use real temporary directories instead of global filesystem mocks. This ensures tests verify actual file operations and handle path resolution nuances correctly. Also fixes a CI failure by adding missing AttestationID scalar to business-platform-organizations GraphQL types.
0b9cedf to
272ec98
Compare
WHY are these changes introduced?
Filesystem mocks in tests prevent verifying actual filesystem side effects and can lead to implementation-coupled tests that don't catch real-world path handling issues.
WHAT is this pull request doing?
Refactors `packages/app/src/cli/services/build/steps/bundle-ui-step.test.ts` to replace global `vi.mock('@shopify/cli-kit/node/fs')` with real filesystem operations using `inTemporaryDirectory`. It uses `mkdir` and `writeFile` to set up the test environment and `fileExists` to verify the success of `copyFile`.
How to test your changes?
CI
Post-release steps
N/A
Checklist
PR created automatically by Jules for task 18014390488825622297 started by @gonzaloriestra