Skip to content

[Refactor] Extract NAME_FAMILIES constant from getRandomName #7570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 2 commits into from
May 20, 2026
Merged

[Refactor] Extract NAME_FAMILIES constant from getRandomName #7570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cf6559
[Refactor] Extract NAME_FAMILIES constant from getRandomName
gonzaloriestra May 18, 2026
e5dab22
Improve typing
gonzaloriestra May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added .jules/refactor.md
View file
Open in desktop
Empty file.
23 changes: 12 additions & 11 deletions packages/cli-kit/src/public/common/string.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,24 +161,25 @@ const SAFE_RANDOM_CREATIVE_NOUNS = [

export type RandomNameFamily = 'business' | 'creative'

const NAME_FAMILIES: Record<RandomNameFamily, {adjectives: string[]; nouns: string[]}> = {
business: {
adjectives: SAFE_RANDOM_BUSINESS_ADJECTIVES,
nouns: SAFE_RANDOM_BUSINESS_NOUNS,
},
creative: {
adjectives: SAFE_RANDOM_CREATIVE_ADJECTIVES,
nouns: SAFE_RANDOM_CREATIVE_NOUNS,
},
}

/**
* Generates a random name by combining an adjective and noun.
*
* @param family - Theme to use for the random name (business or creative).
* @returns A random name generated by combining an adjective and noun.
*/
export function getRandomName(family: RandomNameFamily = 'business'): string {
const mapping = {
business: {
adjectives: SAFE_RANDOM_BUSINESS_ADJECTIVES,
nouns: SAFE_RANDOM_BUSINESS_NOUNS,
},
creative: {
adjectives: SAFE_RANDOM_CREATIVE_ADJECTIVES,
nouns: SAFE_RANDOM_CREATIVE_NOUNS,
},
}
return `${takeRandomFromArray(mapping[family].adjectives)}-${takeRandomFromArray(mapping[family].nouns)}`
return `${takeRandomFromArray(NAME_FAMILIES[family].adjectives)}-${takeRandomFromArray(NAME_FAMILIES[family].nouns)}`
}

/**
Expand Down
Loading