[Performance] Optimize getArrayContainsDuplicates with early exit#7569
[Performance] Optimize getArrayContainsDuplicates with early exit#7569gonzaloriestra wants to merge 1 commit into
Conversation
Optimized the `getArrayContainsDuplicates` utility in `@shopify/cli-kit` to return early as soon as the first duplicate is found. The previous implementation always constructed a full `Set` from the entire array, which resulted in O(n) time and memory overhead even when a duplicate was present at the beginning. New behavior: - Time complexity: O(k) where k is the index of the first duplicate. - Memory complexity: O(k) for the tracking Set.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/array.d.ts@@ -16,6 +16,10 @@ export declare function getArrayRejectingUndefined<T>(array: (T | undefined)[]):
/**
* Returns true if an array contains duplicates.
*
+ * This implementation is optimized to exit early as soon as the first duplicate
+ * is found, avoiding unnecessary processing of the rest of the array.
+ * Time complexity: O(k) where k is the index of the first duplicate, O(n) otherwise.
+ *
* @param array - The array to check against.
* @returns True if the array contains duplicates.
*/
|
WHY are these changes introduced?
The current implementation of
getArrayContainsDuplicatesalways processes the entire array to create aSet, even if a duplicate is found early on. This is inefficient for large arrays with early duplicates.WHAT is this pull request doing?
Refactors
getArrayContainsDuplicatesto use afor...ofloop and aSetto track seen elements, allowing it to returntrueimmediately when a duplicate is encountered.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 12501024952324881799 started by @gonzaloriestra