Skip to content

[Performance] Optimize getArrayContainsDuplicates with early exit#7569

Closed
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-performance-optimize-duplicate-check-12501024952324881799
Closed

[Performance] Optimize getArrayContainsDuplicates with early exit#7569
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-performance-optimize-duplicate-check-12501024952324881799

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The current implementation of getArrayContainsDuplicates always processes the entire array to create a Set, even if a duplicate is found early on. This is inefficient for large arrays with early duplicates.

WHAT is this pull request doing?

Refactors getArrayContainsDuplicates to use a for...of loop and a Set to track seen elements, allowing it to return true immediately when a duplicate is encountered.

How to test your changes?

CI

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 12501024952324881799 started by @gonzaloriestra

Optimized the `getArrayContainsDuplicates` utility in `@shopify/cli-kit`
to return early as soon as the first duplicate is found.
The previous implementation always constructed a full `Set` from the entire array,
which resulted in O(n) time and memory overhead even when a duplicate was present at the beginning.

New behavior:
- Time complexity: O(k) where k is the index of the first duplicate.
- Memory complexity: O(k) for the tracking Set.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/array.d.ts
@@ -16,6 +16,10 @@ export declare function getArrayRejectingUndefined<T>(array: (T | undefined)[]):
 /**
  * Returns true if an array contains duplicates.
  *
+ * This implementation is optimized to exit early as soon as the first duplicate
+ * is found, avoiding unnecessary processing of the rest of the array.
+ * Time complexity: O(k) where k is the index of the first duplicate, O(n) otherwise.
+ *
  * @param array - The array to check against.
  * @returns True if the array contains duplicates.
  */

@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant