Skip to content

[Refactor] Fix incorrect string formatting in addNPMDependencies#7549

Merged
gonzaloriestra merged 1 commit into
mainfrom
refactor-fix-npm-deps-formatting-6314282184458645698
May 20, 2026
Merged

[Refactor] Fix incorrect string formatting in addNPMDependencies#7549
gonzaloriestra merged 1 commit into
mainfrom
refactor-fix-npm-deps-formatting-6314282184458645698

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented May 15, 2026

Copy link
Copy Markdown
Contributor

What was improved

Fixed a minor code quality and formatting issue in addNPMDependencies where an array of dependency strings was being wrapped in another array before calling .join(' '). This resulted in a comma-separated string instead of a space-separated one.

How to test your changes?

Run any command that triggers addNPMDependencies and verify the "Installing ..." output message correctly space-separates multiple dependencies.


PR created automatically by Jules for task 6314282184458645698 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 15, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 18, 2026
@gonzaloriestra gonzaloriestra marked this pull request as ready for review May 18, 2026 11:41
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 18, 2026 11:41
Comment thread packages/cli-kit/src/public/node/node-package-manager.ts
@gonzaloriestra gonzaloriestra force-pushed the refactor-fix-npm-deps-formatting-6314282184458645698 branch from 118fd30 to 324b0ef Compare May 20, 2026 12:52
Change `[dependenciesWithVersion].join(' ')` to `dependenciesWithVersion.join(' ')` in `addNPMDependencies` to ensure correct space-separation of dependencies in the output message.
@gonzaloriestra gonzaloriestra force-pushed the refactor-fix-npm-deps-formatting-6314282184458645698 branch from 324b0ef to c894224 Compare May 20, 2026 13:12
@gonzaloriestra gonzaloriestra enabled auto-merge May 20, 2026 13:13
@gonzaloriestra gonzaloriestra added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 671a7e4 May 20, 2026
26 of 28 checks passed
@gonzaloriestra gonzaloriestra deleted the refactor-fix-npm-deps-formatting-6314282184458645698 branch May 20, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants