[Security] Redact cookies in sanitized headers output#7544
[Security] Redact cookies in sanitized headers output#7544gonzaloriestra wants to merge 1 commit into
Conversation
Modified sanitizedHeadersOutput in @shopify/cli-kit to include 'cookie' in the redacted keywords. This ensures that sensitive session data from Cookie and Set-Cookie headers is not leaked in debug logs. Added unit test coverage to verify the fix.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
WHY are these changes introduced?
To prevent sensitive session information (from `Cookie` and `Set-Cookie` headers) from being exposed in CLI debug logs.
WHAT is this pull request doing?
It adds 'cookie' to the list of keywords that are redacted by the `sanitizedHeadersOutput` function in `@shopify/cli-kit`. This ensures that any header containing the word "cookie" (case-insensitive) is omitted from the sanitized output used for logging.
How to test your changes?
You can verify this by running any command that performs a Shopify API request with the `--verbose` or `--debug` flag (which triggers `shopifyFetch`).
For example:
`shopify app info --verbose`
In the debug output, you should no longer see `Cookie` or `Set-Cookie` headers listed under "With request headers:".
Duplicate check
Query run: `gh pr list --repo Shopify/cli --state all --limit 200 --search 'label:"Jules" "Security" in:title' --json number,title,state,url,body,files` (Note: `gh` was unavailable in the environment, so manual inspection of the codebase and `git log` was used as a fallback).
Checklist
PR created automatically by Jules for task 13079893503620611949 started by @gonzaloriestra